Date:   Thu, 23 Dec 2021 12:24:17 -0800
From:   Richard Cochran <richardcochran@gmail.com>
To:     "Radu Pirea (NXP OSS)" <radu-nicolae.pirea@oss.nxp.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        christian.herber@nxp.com, andrew@lunn.ch, hkallweit1@gmail.com,
        linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org
Subject: Re: [PATCH v2 2/2] phy: nxp-c45-tja11xx: read the tx timestamp
 without lock
Message-ID: <20211223202417.GC29492@hoboy.vegasvil.org>
References: <20211222213453.969005-1-radu-nicolae.pirea@oss.nxp.com>
 <20211222213453.969005-3-radu-nicolae.pirea@oss.nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211222213453.969005-3-radu-nicolae.pirea@oss.nxp.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Wed, Dec 22, 2021 at 11:34:53PM +0200, Radu Pirea (NXP OSS) wrote:
> Reading the tx timestamps can be done in parallel with adjusting the LTC
> value.
> 
> Calls to nxp_c45_get_hwtxts() are always serialised. If the phy
> interrupt is enabled, .do_aux_work() will not call nxp_c45_get_hwtxts.

Reviewing the code, I see what you mean.  However, the serialization
is completely non-obvious, and future changes to the driver could
easily spoil the implicit serialization.  Given that the mutex is not
highly contended, I suggest dropping this patch in order to
future-proof the driver.

Thanks,
Richard