From:   "Liao, Bard" <bard.liao@intel.com>
To:     Mark Brown <broonie@kernel.org>,
        Bard Liao <yung-chuan.liao@linux.intel.com>
CC:     "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "vinod.koul@linaro.org" <vinod.koul@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "tiwai@suse.de" <tiwai@suse.de>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "srinivas.kandagatla@linaro.org" <srinivas.kandagatla@linaro.org>,
        "pierre-louis.bossart@linux.intel.com" 
        <pierre-louis.bossart@linux.intel.com>,
        "Kale, Sanyog R" <sanyog.r.kale@intel.com>
Subject: RE: [PATCH 7/7] soundwire: intel: remove PDM support
Thread-Topic: [PATCH 7/7] soundwire: intel: remove PDM support
Thread-Index: AQHX7+TlYkewtyPq/kiicjsWCVwmBqxAdYoAgABo9uA=
Date:   Fri, 24 Dec 2021 01:38:48 +0000
Message-ID: <DM6PR11MB40746A38CF42DC4DA6C21AC6FF7F9@DM6PR11MB4074.namprd11.prod.outlook.com>
References: <20211213054634.30088-1-yung-chuan.liao@linux.intel.com>
 <20211213054634.30088-8-yung-chuan.liao@linux.intel.com>
 <YcS/cPb0UXsc9SWm@sirena.org.uk>
In-Reply-To: <YcS/cPb0UXsc9SWm@sirena.org.uk>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-reaction: no-action
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jzdajY9wLdtoG/+05h2X97Ee9Mf6MmH0G41S+R9Xd0+WGjwL2CNwsX27th1u?=
 =?us-ascii?Q?1LFBqIlEvNLNWVH2IEcBH2ambaTCncXpl1wGtPsM4DfAHmAwTukXxd+KehkY?=
 =?us-ascii?Q?MhXm/Uiw6EwgH7jUut1KatpneOwb2+U30APfFppo7m2vKHguoWZl/WDJSpUP?=
 =?us-ascii?Q?65bRXLjIraW0VCkISc+5CZgQpJrTVNSFFRpdgdECWV+Lt4w57SN00n6JBlfJ?=
 =?us-ascii?Q?v5lC+bhBHO1D/WAVDKRQdb8qA13Gom0aenOkdXNqO9doVc4NQs0sljJWW5p2?=
 =?us-ascii?Q?KPTpo6+EuaMTE9md16TvE1hiJOLPCo9n/2CNPKQHdI17pni4yqyySnPA3pO7?=
 =?us-ascii?Q?9azG2gLmgluhYVwHY76PSgk4Gv1uL2I5okj1OS/MpiI9rTpjJlBjKaPfQKVp?=
 =?us-ascii?Q?8MnG8lg7GUYHvYkvYhPLHUU3XMTqD4vubhxGnqPGYjGPvOVeqCFU+1OVgKb0?=
 =?us-ascii?Q?A6ZVBcBv1N5t0PSmG5XTFmdsudUHru+zzrKfddi9LqWpI9Lv/xByEBRlV9PP?=
 =?us-ascii?Q?hT4u8hP5QdyevYQhgf80qpbooL5LHgqgNNGSrxJnynvrIs0FvCyzv3wTYx0Z?=
 =?us-ascii?Q?KeCDxcGybRsa9FfnFQQuAloH3VAo80Fwu2W02FlgMq5hVqbL9KG3GySumJ3U?=
 =?us-ascii?Q?2QsQrljjcPPXu8u0SELivkGBkunjv+SgbZAhvT/l5u9evRYX8akuKgZpEHTj?=
 =?us-ascii?Q?El9wxpV96dkUPiA4PvEo9PHcv6J+a4hDvgsQi9F5IsVgdfKSji42X/0hhpVV?=
 =?us-ascii?Q?A+zDXweGfSnsdLpoJbxI87Khm2QAuNn42t0wKLleJG5nbqrFHJjVxnsgkoSU?=
 =?us-ascii?Q?DsznpFeqdBOiZGmbM9C43fB0yIfRbCBHjbeeIEOPiXWYeOfm4EhsQNABcpgJ?=
 =?us-ascii?Q?o9ejLOakcrBy8dZmOJAWMV7jMoNYvClCQ7AYJUMEtH6AwDRSY8oSJHTFzZEb?=
 =?us-ascii?Q?0eXcfpoIpugsveOsaGt6jssNXx0kW/lONZLvN+uRwr9SVMZDI2TCE6PzgaVo?=
 =?us-ascii?Q?E3ExoP6VelwLavBDs4JcptpMuOPzegBorLebxad5KP7kpA9IKOHPuMgyTe0i?=
 =?us-ascii?Q?IKVz4GSYsk1pEmKkCfvLXkyTfcOw60aRDdd+tUmPs+rGJNH8EcR41/PpFwaE?=
 =?us-ascii?Q?xa1XZc04zGatD19UpP2bWbR1rw43DvORIbkbLqYwZbF/zej0E+TLzRruJf6T?=
 =?us-ascii?Q?SaAtihwI9DJY9rm9GlwSdNZEwLQCKgMbXAf3ttIUW70GJHbAWDf0qkMyDdTK?=
 =?us-ascii?Q?8rQxpVslOBY9Cya8cbYb4zui44zdKny/k7s5Uuv0jwtJkGQ9W+zRvSt4KlX5?=
 =?us-ascii?Q?mn8XkpOjIBgJi59TIfyQT4Skh+C8MRU925NLGkOLOJfoMBQwMIddoI3GwvcL?=
 =?us-ascii?Q?dwx1wInjGtiE/K5uJN4y8fx9AJ4+Lpr83YmC7F5CgbXgc03piggzCdcb+N6L?=
 =?us-ascii?Q?XMr6EtsvM5VlW6BihGzlH4KFTIEXqOpXHs554F/AF/eUhYICr6sByupYtBCW?=
 =?us-ascii?Q?lijcakN5vBwjMk4KClI01qXQjtNd4LtaiYCfBmmrhbj/bSYoaHI1qyA9on4x?=
 =?us-ascii?Q?iq6Sh4fwSrJz+LEYkqLqAKu2bfovlP0xdtC6fbv32AViVq1n2bGI6dKh2Kcd?=
 =?us-ascii?Q?7Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4074.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a651a0a9-2af6-4426-5cc3-08d9c67e21e3
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2021 01:38:48.4957
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ISL17VMKyhYRfvX2jOvhOSRlXoJttYwd02Iq9adBwXXd4bYEJ1WsS6pwONr/tzp/1izC6+blPaq/70GkJmCaQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2985
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Friday, December 24, 2021 2:27 AM
> To: Bard Liao <yung-chuan.liao@linux.intel.com>
> Cc: alsa-devel@alsa-project.org; vkoul@kernel.org; vinod.koul@linaro.org;
> linux-kernel@vger.kernel.org; tiwai@suse.de; gregkh@linuxfoundation.org;
> srinivas.kandagatla@linaro.org; pierre-louis.bossart@linux.intel.com; Kal=
e,
> Sanyog R <sanyog.r.kale@intel.com>; Liao, Bard <bard.liao@intel.com>
> Subject: Re: [PATCH 7/7] soundwire: intel: remove PDM support
>=20
> On Mon, Dec 13, 2021 at 01:46:34PM +0800, Bard Liao wrote:
> > From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> >
> > While the hardware supports PDM streams, this capability has never
> > been tested or enabled on any product, so this is dead-code. Let's
> > remove all this.
>=20
> This doesn't build with current code, I'm guessing due to a Soundwire
> dependency I don't have:

Hi Mark,

Sorry, it is my fault.  "[PATCH 7/7] soundwire: intel: remove PDM support"
was before "[PATCH 4/7] ASoC/SoundWire: dai: expand 'stream' concept
beyond". So there was no "intel_pdm_dai_ops" stuff in the "ASoC/SoundWire:=
=20
dai: expand 'stream' concept beyond" patch.
But when I re-order the patches order, the intel_pdm_dai_ops stuff was
still in the "ASoC/SoundWire:  dai: expand 'stream' concept beyond" patch
and I forgot rename set_sdw_stream and get_sdw_stream ops in
intel_pdm_dai_ops.
I will send v2 to fix it. Sorry about it.

>=20
> /mnt/kernel/drivers/soundwire/intel.c:1142:3: error: 'const struct
> snd_soc_dai_ops' has no member named 'set_sdw_stream'; did you mean
> 'set_stream'?
>  1142 |  .set_sdw_stream =3D intel_pdm_set_sdw_stream,
>       |   ^~~~~~~~~~~~~~
>       |   set_stream
> /mnt/kernel/drivers/soundwire/intel.c:1142:20: error: initialization of '=
int
> (*)(struct snd_pcm_substream *, struct snd_pcm_hw_params *, struct
> snd_soc_dai *)' from incompatible pointer type 'int (*)(struct snd_soc_da=
i *,
> void *, int)' [-Werror=3Dincompatible-pointer-types]
>  1142 |  .set_sdw_stream =3D intel_pdm_set_sdw_stream,
>       |                    ^~~~~~~~~~~~~~~~~~~~~~~~
> /mnt/kernel/drivers/soundwire/intel.c:1142:20: note: (near initialization=
 for
> 'intel_pdm_dai_ops.hw_params')
> /mnt/kernel/drivers/soundwire/intel.c:1143:3: error: 'const struct
> snd_soc_dai_ops' has no member named 'get_sdw_stream'; did you mean
> 'get_stream'?
>  1143 |  .get_sdw_stream =3D intel_get_sdw_stream,
>       |   ^~~~~~~~~~~~~~
>       |   get_stream
> /mnt/kernel/drivers/soundwire/intel.c:1143:20: error: initialization of '=
int
> (*)(struct snd_pcm_substream *, struct snd_soc_dai *)' from incompatible
> pointer type 'void * (*)(struct snd_soc_dai *, int)' [-Werror=3Dincompati=
ble-
> pointer-types]
>  1143 |  .get_sdw_stream =3D intel_get_sdw_stream,
>       |                    ^~~~~~~~~~~~~~~~~~~~
> /mnt/kernel/drivers/soundwire/intel.c:1143:20: note: (near initialization=
 for
> 'intel_pdm_dai_ops.hw_free')
> cc1: all warnings being treated as errors
> make[3]: *** [/mnt/kernel/scripts/Makefile.build:287:
> drivers/soundwire/intel.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> make[2]: *** [/mnt/kernel/scripts/Makefile.build:549: drivers/soundwire]
> Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/mnt/kernel/Makefile:1846: drivers] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:219: __sub-make] Error 2