Date:   Thu, 23 Dec 2021 19:14:14 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     robin.murphy@arm.com, andy.shevchenko@gmail.com,
        davem@davemloft.net, yangyingliang@huawei.com, sashal@kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] fjes: Check for error irq
Message-ID: <20211223191414.1328c7be@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <20211224013445.1400507-1-jiasheng@iscas.ac.cn>
References: <20211224013445.1400507-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 24 Dec 2021 09:34:45 +0800 Jiasheng Jiang wrote:
> The platform_get_irq() is possible to fail.
> And the returned irq could be error number and will finally cause the
> failure of the request_irq().
> Consider that platform_get_irq() can now in certain cases return
> -EPROBE_DEFER, and the consequences of letting request_irq() effectively
> convert that into -EINVAL, even at probe time rather than later on.
> So it might be better to check just now.
> 
> Fixes: 658d439b2292 ("fjes: Introduce FUJITSU Extended Socket Network Device driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Please take note of the notifications you're getting. The previous
versions of this and the other two patches you posted shortly after
were already merged into the net tree:

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=db6d6afe382de5a65d6ccf51253ab48b8e8336c3

If you want to refactor the check you need to send an incremental
change (IOW diff against the previously applied patch).