Date:   Fri, 24 Dec 2021 08:00:55 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     Jason Gunthorpe <jgg@nvidia.com>
Cc:     Maor Gottlieb <maorg@nvidia.com>, alaa@nvidia.com,
        chuck.lever@oracle.com, linux-kernel@vger.kernel.org,
        linux-rdma@vger.kernel.org, tonylu@linux.alibaba.com
Subject: Re: [PATCH rdma-rc] Revert "RDMA/mlx5: Fix releasing unallocated
 memory in dereg MR flow"
Message-ID: <YcViF8yyTfuedh38@unreal>
References: <20211222101312.1358616-1-maorg@nvidia.com>
 <20211224025145.GE1779224@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211224025145.GE1779224@nvidia.com>
Precedence: bulk

On Thu, Dec 23, 2021 at 10:51:45PM -0400, Jason Gunthorpe wrote:
> On Wed, Dec 22, 2021 at 12:13:12PM +0200, Maor Gottlieb wrote:
> > This patch is not the full fix and still causes to call traces
> > during mlx5_ib_dereg_mr().
> > 
> > This reverts commit f0ae4afe3d35e67db042c58a52909e06262b740f.
> > 
> > Fixes: f0ae4afe3d35 ("RDMA/mlx5: Fix releasing unallocated memory in dereg MR flow")
> > Signed-off-by: Maor Gottlieb <maorg@nvidia.com>
> > ---
> >  drivers/infiniband/hw/mlx5/mlx5_ib.h |  6 +++---
> >  drivers/infiniband/hw/mlx5/mr.c      | 26 ++++++++++++++------------
> >  2 files changed, 17 insertions(+), 15 deletions(-)
> 
> Huh? Why is this such a problem to fix the missing udatas?

Because of internal structure of Nvidia/Mellanox, we are having very
hard time to properly test any fix in ULP area.

In addition, the vacation season doesn't help either.

Feel free to approach me or Maor offline and we will explain you the
non-technical details behind this revert.

Thanks

> 
> Jason