From:   Christophe Leroy <christophe.leroy@csgroup.eu>
To:     Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Michael Ellerman <mpe@ellerman.id.au>
CC:     Christophe Leroy <christophe.leroy@csgroup.eu>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        Maxime Bizon <mbizon@freebox.fr>,
        Russell Currey <ruscur@russell.cc>
Subject: [PATCH v3 1/2] powerpc/set_memory: Avoid spinlock recursion in
 change_page_attr()
Thread-Topic: [PATCH v3 1/2] powerpc/set_memory: Avoid spinlock recursion in
 change_page_attr()
Thread-Index: AQHX+LZz8qLd0m1ne0WotvwFO7oMmA==
Date:   Fri, 24 Dec 2021 11:07:33 +0000
Message-ID: <43c3c76a1175ae6dc1a3d3b5c3f7ecb48f683eea.1640344012.git.christophe.leroy@csgroup.eu>
Accept-Language: fr-FR, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?G/ONU0JNODi3vo9+B9E1vbWGwTtyb8Lxc7j5uhISNrsFs7aNrIc+9QDpj1?=
 =?iso-8859-1?Q?pwpd9QtGmAfbuhVdROwmHiTXZxAB07+2+7lJanZUVqBUjP84k0p2Rsd5ga?=
 =?iso-8859-1?Q?8IYEUbeRa+oaqaSyT5SfTgfBtqs0LclXeNdBMs70WWeISgbftsGmzWC9Cs?=
 =?iso-8859-1?Q?SIhSoP6xHKJL0TCy5CqetXoYH2oREUt3+g27cbxeGJr+pil/M28RDjQIqw?=
 =?iso-8859-1?Q?17vbqsMdqWUVNHIed5AJT/+uj45fgJ5bOpkWNDMktvBGOGlNaiDJ9R/hcn?=
 =?iso-8859-1?Q?tYjs8J1HR/dpUXyc/qQSE5hoInvLtXFluc/UtjABUEnB67qsCbrErVR8yS?=
 =?iso-8859-1?Q?ROns5U2vHgfgSIf1mQ3JMB7mcK06VVuOZItaBPw8++4RX1fGws23SdJx3f?=
 =?iso-8859-1?Q?fgg89JK/J1JRzUGuRlNq/DyqyBlsnZY9e1coVnQEFEtOOH2xRVS3KH1/r7?=
 =?iso-8859-1?Q?Jb5va5DtAFSDo9eHhOXKgaW1jp/g9usJS44vpztVsGylSXfQoWg8bCQNl4?=
 =?iso-8859-1?Q?uzbzrgQ2X/u760oiOXRrB0RYa56Yc8/qRb+vu5LwtRlFyc5O9hyITxPFHK?=
 =?iso-8859-1?Q?55b9tNRhs5hvFLeqO5k7tICnP7jFbnl8DHM3h7j2xe4POTzeEAlzjgWDls?=
 =?iso-8859-1?Q?P8CW/eQO78kG+U2OTNUbDV9RpupeGpVq5Kuxiny4cAGZinsvv9fK60B4hD?=
 =?iso-8859-1?Q?DoRCeqP/KC7QhtOq3XdJrtXhVBFr+X3Oh0uUdIsi3srtWwECBHEkEZPYWs?=
 =?iso-8859-1?Q?TdWhnXKJgDtv50kQel5L2i8NSfgYgFpsr53mIF7QEt4Ca+G/0+W+d6aXjp?=
 =?iso-8859-1?Q?6f08w7pnqlD05eTaz4Lv2ghYWcNQj8gaQVRUyoyteWfjXgB2WcmrRjP+SN?=
 =?iso-8859-1?Q?UyHiGaSEovBwuNO0UX7JPxbjT58RCcnSzqTK853QWiBPkW3Rla8z7E8eYy?=
 =?iso-8859-1?Q?S61lkmhLEvxeUO64mC7vzt0HtV6Gf4X0MZqQmkyyMQECKIEDtelUeuAKzf?=
 =?iso-8859-1?Q?+KDF5d4gBx9wSsP0CFETJ1tUBXsLQojpFM8TADUfFbw5Smb+fO1SuXMW8+?=
 =?iso-8859-1?Q?L71F2TQb4SH0YFkzOZryVleI4czA9z1Kdm59tIy+mIrDuZDsia/GNyIpbE?=
 =?iso-8859-1?Q?0BW9NLzB15beCQ2lu70P2V9yn6RgRMCtvFQeC46KAd3C3TDCRa6F3p6fql?=
 =?iso-8859-1?Q?lSGOvZ/9QPwRMm9doa12QQ/txREeWrM0qbmOTGCcPZFzY73ldRmSuxxgzR?=
 =?iso-8859-1?Q?5x46wr29k/zIbPOxXay7bVmXiayYaQwfPEdPCjxm1x88WFl19J6/NXQCJ9?=
 =?iso-8859-1?Q?f3wZpgnbOoUqymzcX+eB83P7pmWQEz1YwkKIfWiaGhAnI9kiga/Mo7kYMm?=
 =?iso-8859-1?Q?+p+cc1uOljwP3A47faPm+GvVD7BYbe5W2CSFwZOmQignUIaKPyCQNaSafg?=
 =?iso-8859-1?Q?zSV3MwUaPKk3lvfu2vV0MJljuAZ5GW8g7K2Wxhnu3WnTbjr772zESjMY4n?=
 =?iso-8859-1?Q?FgiXQyDc+bV87jnDedyhH55DHsV9k20GG+eUE/sUnM7UnRKwmNC2FePkI0?=
 =?iso-8859-1?Q?Ni7zWqMfbgsIv5ujYfAYNdEwio/GMLwF5BUiNM5PaEyXk7VMmwGUeLS7+P?=
 =?iso-8859-1?Q?1VlpRV+Kfon4dDFuhQMhNfoifBFEXJxDxj364NTqYBuZPYi3xLJvDsF8cL?=
 =?iso-8859-1?Q?qCp6enCZXMJ6tojDdxJdD/CHDNSi/AbrIBovNPJaAb9eK6iOKgRhO+qQ/u?=
 =?iso-8859-1?Q?JtHr2YwKpKbZsKEuuqLM9NVxs=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-OriginatorOrg: csgroup.eu
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MRZP264MB2988.FRAP264.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 473d59b2-c065-4008-4f91-08d9c6cd963a
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2021 11:07:33.9542
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 9914def7-b676-4fda-8815-5d49fb3b45c8
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KirlBBPWKmCBXT04xO35KR51Bed1AhF0lbo5oOMYwtxczl/dBRjc8Gl7BDu4lP/i5qEgK5s1nu7gRVk4aDuRABtVvE8tCdAxvRBildEMrA8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MRXP264MB0005
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Commit 1f9ad21c3b38 ("powerpc/mm: Implement set_memory() routines")
included a spin_lock() to change_page_attr() in order to
safely perform the three step operations. But then
commit 9f7853d7609d ("powerpc/mm: Fix set_memory_*() against
concurrent accesses") modify it to use pte_update() and do
the operation safely against concurrent access.

In the meantime, Maxime reported some spinlock recursion.

[   15.351649] BUG: spinlock recursion on CPU#0, kworker/0:2/217
[   15.357540]  lock: init_mm+0x3c/0x420, .magic: dead4ead, .owner: kworker/0:2/217, .owner_cpu: 0
[   15.366563] CPU: 0 PID: 217 Comm: kworker/0:2 Not tainted 5.15.0+ #523
[   15.373350] Workqueue: events do_free_init
[   15.377615] Call Trace:
[   15.380232] [e4105ac0] [800946a4] do_raw_spin_lock+0xf8/0x120 (unreliable)
[   15.387340] [e4105ae0] [8001f4ec] change_page_attr+0x40/0x1d4
[   15.393413] [e4105b10] [801424e0] __apply_to_page_range+0x164/0x310
[   15.400009] [e4105b60] [80169620] free_pcp_prepare+0x1e4/0x4a0
[   15.406045] [e4105ba0] [8016c5a0] free_unref_page+0x40/0x2b8
[   15.411979] [e4105be0] [8018724c] kasan_depopulate_vmalloc_pte+0x6c/0x94
[   15.418989] [e4105c00] [801424e0] __apply_to_page_range+0x164/0x310
[   15.425451] [e4105c50] [80187834] kasan_release_vmalloc+0xbc/0x134
[   15.431898] [e4105c70] [8015f7a8] __purge_vmap_area_lazy+0x4e4/0xdd8
[   15.438560] [e4105d30] [80160d10] _vm_unmap_aliases.part.0+0x17c/0x24c
[   15.445283] [e4105d60] [801642d0] __vunmap+0x2f0/0x5c8
[   15.450684] [e4105db0] [800e32d0] do_free_init+0x68/0x94
[   15.456181] [e4105dd0] [8005d094] process_one_work+0x4bc/0x7b8
[   15.462283] [e4105e90] [8005d614] worker_thread+0x284/0x6e8
[   15.468227] [e4105f00] [8006aaec] kthread+0x1f0/0x210
[   15.473489] [e4105f40] [80017148] ret_from_kernel_thread+0x14/0x1c

Remove the read / modify / write sequence to make the operation atomic
and remove the spin_lock() in change_page_attr().

To do the operation atomically, we can't use pte modification helpers
anymore. Because all platforms have different combination of bits, it
is not easy to use those bits directly. But all have the
_PAGE_KERNEL_{RO/ROX/RW/RWX} set of flags. All we need it to compare
two sets to know which bits are set or cleared.

For instance, by comparing _PAGE_KERNEL_ROX and _PAGE_KERNEL_RO you
know which bit gets cleared and which bit get set when changing exec
permission.

Reported-by: Maxime Bizon <mbizon@freebox.fr>
Link: https://lore.kernel.org/all/20211212112152.GA27070@sakura/
Cc: Russell Currey <ruscur@russell.cc>
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
---
v3: Use pte_update() directly instead of having a read / modify / write sequence
---
 arch/powerpc/mm/pageattr.c | 32 +++++++++++++-------------------
 1 file changed, 13 insertions(+), 19 deletions(-)

diff --git a/arch/powerpc/mm/pageattr.c b/arch/powerpc/mm/pageattr.c
index edea388e9d3f..8812454e70ff 100644
--- a/arch/powerpc/mm/pageattr.c
+++ b/arch/powerpc/mm/pageattr.c
@@ -15,12 +15,14 @@
 #include <asm/pgtable.h>
 
 
+static pte_basic_t pte_update_delta(pte_t *ptep, unsigned long addr,
+				    unsigned long old, unsigned long new)
+{
+	return pte_update(&init_mm, addr, ptep, old & ~new, new & ~old, 0);
+}
+
 /*
- * Updates the attributes of a page in three steps:
- *
- * 1. take the page_table_lock
- * 2. install the new entry with the updated attributes
- * 3. flush the TLB
+ * Updates the attributes of a page atomically.
  *
  * This sequence is safe against concurrent updates, and also allows updating the
  * attributes of a page currently being executed or accessed.
@@ -28,41 +30,33 @@
 static int change_page_attr(pte_t *ptep, unsigned long addr, void *data)
 {
 	long action = (long)data;
-	pte_t pte;
-
-	spin_lock(&init_mm.page_table_lock);
-
-	pte = ptep_get(ptep);
 
-	/* modify the PTE bits as desired, then apply */
+	/* modify the PTE bits as desired */
 	switch (action) {
 	case SET_MEMORY_RO:
-		pte = pte_wrprotect(pte);
+		/* Don't clear DIRTY bit */
+		pte_update_delta(ptep, addr, _PAGE_KERNEL_RW & ~_PAGE_DIRTY, _PAGE_KERNEL_RO);
 		break;
 	case SET_MEMORY_RW:
-		pte = pte_mkwrite(pte_mkdirty(pte));
+		pte_update_delta(ptep, addr, _PAGE_KERNEL_RO, _PAGE_KERNEL_RW);
 		break;
 	case SET_MEMORY_NX:
-		pte = pte_exprotect(pte);
+		pte_update_delta(ptep, addr, _PAGE_KERNEL_ROX, _PAGE_KERNEL_RO);
 		break;
 	case SET_MEMORY_X:
-		pte = pte_mkexec(pte);
+		pte_update_delta(ptep, addr, _PAGE_KERNEL_RO, _PAGE_KERNEL_ROX);
 		break;
 	default:
 		WARN_ON_ONCE(1);
 		break;
 	}
 
-	pte_update(&init_mm, addr, ptep, ~0UL, pte_val(pte), 0);
-
 	/* See ptesync comment in radix__set_pte_at() */
 	if (radix_enabled())
 		asm volatile("ptesync": : :"memory");
 
 	flush_tlb_kernel_range(addr, addr + PAGE_SIZE);
 
-	spin_unlock(&init_mm.page_table_lock);
-
 	return 0;
 }
 
-- 
2.33.1