MIME-Version: 1.0
References: <20211220084602.952091-1-wangborong@cdjrlc.com>
In-Reply-To: <20211220084602.952091-1-wangborong@cdjrlc.com>
From:   Max Filippov <jcmvbkbc@gmail.com>
Date:   Fri, 24 Dec 2021 03:28:42 -0800
Message-ID: <CAMo8Bf+731hRJ-HTbE7Co_1Hfdhf09vQ_Sqk9gS0DOam3V5gAQ@mail.gmail.com>
Subject: Re: [PATCH] net: xtensa: use strscpy to copy strings
To:     Jason Wang <wangborong@cdjrlc.com>
Cc:     Chris Zankel <chris@zankel.net>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        "open list:TENSILICA XTENSA PORT (xtensa)" 
        <linux-xtensa@linux-xtensa.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Dec 20, 2021 at 12:46 AM Jason Wang <wangborong@cdjrlc.com> wrote:
>
> The strlcpy should not be used because it doesn't limit the source
> length. So that it will lead some potential bugs.
>
> But the strscpy doesn't require reading memory from the src string
> beyond the specified "count" bytes, and since the return value is
> easier to error-check than strlcpy()'s. In addition, the implementation
> is robust to the string changing out from underneath it, unlike the
> current strlcpy() implementation.
>
> Thus, replace strlcpy with strscpy.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
>  arch/xtensa/platforms/iss/network.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to my xtensa tree. Thanks.

-- Max