Date:   Fri, 24 Dec 2021 10:57:04 -0300
From:   Bruno Meneguele <bmeneg@redhat.com>
To:     Mimi Zohar <zohar@linux.ibm.com>
Cc:     linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ima: silence measurement list hexdump during kexec
Message-ID: <YcXRsLxFsMCQeYJ6@glitch>
References: <20211224131454.45577-1-bmeneg@redhat.com>
 <c3a1c7afed5962da2bf89d347fa5eea5fea40daf.camel@linux.ibm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="wr48hpfUzuL4NGwl"
Content-Disposition: inline
In-Reply-To: <c3a1c7afed5962da2bf89d347fa5eea5fea40daf.camel@linux.ibm.com>
Precedence: bulk


--wr48hpfUzuL4NGwl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Mimi,

On Fri, Dec 24, 2021 at 08:28:01AM -0500, Mimi Zohar wrote:
> Hi Bruno,
>=20
> On Fri, 2021-12-24 at 10:14 -0300, Bruno Meneguele wrote:
> > The measurement list is dumped during a soft reset (kexec) through the =
call
> > to print_hex_dump(KERN_DEBUG, ...), printing to the system log ignoring=
 both
> > DEBUG build flag and CONFIG_DYNAMIC_DEBUG option.
>=20
> Before upstreaming this patch, the reason for the config options "being
> ignored", if that is really what is happening, needs to be understood
> and documented here in the patch description.

I don't see why the code would intentionally ignore the option,
considering that CONFIG_DYNAMIC_DEBUG basically give the user the
ability to enable/disable pr_debug/printk(KERN_DEBUG) calls during
runtime. Maybe I shouldn't use the word "ignoring" in the description,
would it make things clearer?

>=20
> thanks,
>=20
> Mimi
>=20
> >=20
> > To honor the above conditions the macro print_hex_dump_debug() should be
> > used instead, thus depending on the enabled option/flag the output is g=
iven
> > by a different function call or even silenced.
> >=20
> > Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
>=20

--=20
bmeneg=20
PGP Key: http://bmeneg.com/pubkey.txt

--wr48hpfUzuL4NGwl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEdWo6nTbnZdbDmXutYdRkFR+RokMFAmHF0bAACgkQYdRkFR+R
okN/mQgAoczefwSZW9duV1llX85yUc6FDLKgNuqfQ3A0Ntz8wXw6sQ19WLkpXs0P
OivxILmNWtFR/voP2p/m5P8FfhE6aPtqQO7GZDkLlGx0ytDEVQqLEhBmwkSsoE4V
IIq7zJUmlV6/1p7aUZkmMnOGsItbY2gOt7kLThBh6kCVokJj+kW48KopPAywqw5P
Hrs+VvGYLCxKumOh1vC6mkldn7W97YWJ5a0by2C/XTPbZHA4I3Q6ef2dgdo9P/xp
DzgQ9KRI7x/6TSADXteQzpNEORUEYCl+IBoDvKtjlW+Rv9vIa3zl4ftzA3rWUBkm
uW2fM56+9lKxJ70fgm70Jy+agX+qzg==
=5je9
-----END PGP SIGNATURE-----

--wr48hpfUzuL4NGwl--