Date:   Fri, 24 Dec 2021 14:06:37 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     matthias.bgg@gmail.com, lgirdwood@gmail.com,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] isoc: mediatek: Check for error clk pointer
Message-ID: <YcXT7bUpVL/JyAz4@sirena.org.uk>
References: <20211222015157.1025853-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="YSEnFLCeyQGawA2l"
Content-Disposition: inline
In-Reply-To: <20211222015157.1025853-1-jiasheng@iscas.ac.cn>
Precedence: bulk


--YSEnFLCeyQGawA2l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 22, 2021 at 09:51:57AM +0800, Jiasheng Jiang wrote:
> On Wed, Dec 22, 2021 at 01:57:15AM +0800, Mark Brown wrote:
> >> +	for (i =3D CLK_NONE + 1; i < CLK_MAX; i++) {
> >>  		clk[i] =3D devm_clk_get(&pdev->dev, clk_names[i]);
> >> +		if (IS_ERR(clk[i]))
> >> +			return PTR_ERR(clk[i]);
> >
> > This now pays attention to the error code here which is good but...
> >
> >> -	init_clks(pdev, clk);
> >> +	ret =3D init_clks(pdev, clk);
> >> +	if (ret)
> >> +		return ERR_PTR(-ENOMEM);
> >
> > ...then discards it here with a random most likely inappropriate error
> > code.
>=20
> Yes, you are right and now the return code depending on the
> init_clks().

Please submit patches in the format covered in submitting-patches.rst -
write a proper changelog for your patches.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

--YSEnFLCeyQGawA2l
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmHF0+wACgkQJNaLcl1U
h9ClSwf9G7UDRag5kdedyFEo47nCabkadilrQ6nYUYbag4e0I2vSap5h04MAalS8
J6Kih1+U6lc4PouNCcHb70X2DeS4PntOIdiqfPNBCTfQjkbncq3JXmthcJdRu7OC
nvcEM8xBTHNJ13xMenWZRL3zVMb5v9d8UlsPm7TgDf9XLZayNrx3YPSRglRvCnQM
UHoHkZa/3vMKmz9hZk31vSy6Wh4QuhEqgeVoUw8WCnc9oNOntwwhTOjsP5KtlAd7
9bIgPpLFgyXU8vlwKVJYaZ7levvzIGGgIJNhG49LDFRuegUab5KhT+BPcegvdtMV
koBzaHgZSUBujKOrTNCDV3G+nbyjTw==
=UCt8
-----END PGP SIGNATURE-----

--YSEnFLCeyQGawA2l--