Subject: Re: [PATCH v18 04/17] x86/setup: Add helper
 parse_crashkernel_in_order()
To:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        <x86@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
        <linux-kernel@vger.kernel.org>, Dave Young <dyoung@redhat.com>,
        Baoquan He <bhe@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
        Eric Biederman <ebiederm@xmission.com>,
        <kexec@lists.infradead.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        "Will Deacon" <will@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        <devicetree@vger.kernel.org>, Jonathan Corbet <corbet@lwn.net>,
        <linux-doc@vger.kernel.org>
CC:     Randy Dunlap <rdunlap@infradead.org>,
        Feng Zhou <zhoufeng.zf@bytedance.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        "Chen Zhou" <dingguo.cz@antgroup.com>,
        John Donnelly <John.p.donnelly@oracle.com>
References: <20211222130820.1754-1-thunder.leizhen@huawei.com>
 <20211222130820.1754-5-thunder.leizhen@huawei.com>
From:   "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Message-ID: <9291bf01-d295-583c-399c-ea5b544be474@huawei.com>
Date:   Sat, 25 Dec 2021 09:58:57 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <20211222130820.1754-5-thunder.leizhen@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021/12/22 21:08, Zhen Lei wrote:
> Currently, there are two possible combinations of configurations.
> (1) crashkernel=X[@offset]
> (2) crashkernel=X,high, with or without crashkernel=X,low
> 
> (1) has the highest priority, if it is configured correctly, (2) will be
> ignored. Similarly, in combination (2), crashkernel=X,low is valid only
> when crashkernel=X,high is valid.
> 
> Putting the operations of parsing all "crashkernel=" configurations in one
> function helps to sort out the strong dependency.
> 
> So add helper parse_crashkernel_in_order(). The "__maybe_unused" will be
> removed in the next patch.
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  arch/x86/kernel/setup.c | 51 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
> 
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index d9080bfa131a654..f997074d36f2484 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -439,6 +439,57 @@ static int __init reserve_crashkernel_low(void)
>  }
>  #endif
>  
> +#define CRASHKERNEL_MEM_NONE		0x0	/* crashkernel= is not exist or invalid */
> +#define CRASHKERNEL_MEM_CLASSIC		0x1	/* crashkernel=X[@offset] is valid */
> +#define CRASHKERNEL_MEM_HIGH		0x2	/* crashkernel=X,high is valid */
> +#define CRASHKERNEL_MEM_LOW		0x4	/* crashkernel=X,low is valid */
> +
> +/**
> + * parse_crashkernel_in_order - Parse all "crashkernel=" configurations in
> + *				priority order until a valid combination is found.
> + * @cmdline:	The bootup command line.
> + * @system_ram: Total system memory size.
> + * @crash_size: Save the memory size specified by "crashkernel=X[@offset]" or
> + *		"crashkernel=X,high".
> + * @crash_base: Save the base address specified by "crashkernel=X@offset"
> + * @low_size:	Save the memory size specified by "crashkernel=X,low"
> + *
> + * Returns the status flag of the parsing result of "crashkernel=", such as
> + * CRASHKERNEL_MEM_NONE, CRASHKERNEL_MEM_HIGH.
> + */
> +__maybe_unused
> +static int __init parse_crashkernel_in_order(char *cmdline,
> +					     unsigned long long system_ram,
> +					     unsigned long long *crash_size,
> +					     unsigned long long *crash_base,
> +					     unsigned long long *low_size)

I rethought yesterday that this function name is not self-annotated. In addition,
the meaning of the return value is not mainstream. It would be better to change it
to parse_crashkernel_high_low().

> +{
> +	int ret, flag = CRASHKERNEL_MEM_NONE;
> +
> +	BUG_ON(!crash_size || !crash_base || !low_size);
> +
> +	/* crashkernel=X[@offset] */
> +	ret = parse_crashkernel(cmdline, system_ram, crash_size, crash_base);
> +	if (!ret && crash_size > 0)
> +		return CRASHKERNEL_MEM_CLASSIC;
> +
> +#ifdef CONFIG_X86_64
> +	/* crashkernel=X,high */
> +	ret = parse_crashkernel_high(cmdline, system_ram, crash_size, crash_base);
> +	if (ret || crash_size <= 0)
> +		return CRASHKERNEL_MEM_NONE;
> +
> +	flag = CRASHKERNEL_MEM_HIGH;
> +
> +	/* crashkernel=Y,low */
> +	ret = parse_crashkernel_low(cmdline, system_ram, low_size, crash_base);
> +	if (!ret)
> +		flag |= CRASHKERNEL_MEM_LOW;
> +#endif
> +
> +	return flag;
> +}
> +
>  static void __init reserve_crashkernel(void)
>  {
>  	unsigned long long crash_size, crash_base, total_mem;
>