MIME-Version: 1.0
References: <20211222171915.9053-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20211222171915.9053-3-prabhakar.mahadev-lad.rj@bp.renesas.com> <CAHp75VccFMoTxR=ws=Us4UW=-Qsr6hVWcKH+pgShJQMdPfKQ_Q@mail.gmail.com>
In-Reply-To: <CAHp75VccFMoTxR=ws=Us4UW=-Qsr6hVWcKH+pgShJQMdPfKQ_Q@mail.gmail.com>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Sat, 25 Dec 2021 14:54:21 +0000
Message-ID: <CA+V-a8uHJmVVMHD-kdPXb=f-5wkoeVvDEwG7=siTYuv6_r=xgg@mail.gmail.com>
Subject: Re: [PATCH 2/2] gpio: rcar: Use platform_get_irq() to get the interrupt
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Andy,

Thank you for the review.

On Sat, Dec 25, 2021 at 2:49 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Fri, Dec 24, 2021 at 9:21 PM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> >
> > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> > allocation of IRQ resources in DT core code, this causes an issue
> > when using hierarchical interrupt domains using "interrupts" property
> > in the node as this bypassed the hierarchical setup and messed up the
> > irq chaining.
> >
> > In preparation for removal of static setup of IRQ resource from DT core
> > code use platform_get_irq().
>
> ...
>
> > -       if (devm_request_irq(dev, irq->start, gpio_rcar_irq_handler,
> > +       if (devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler,
> >                              IRQF_SHARED, name, p)) {
> >                 dev_err(dev, "failed to request IRQ\n");
> >                 ret = -ENOENT;
>
> While at it, you may unshadow the error code
> ret = devm_request_irq(...);
> if (ret) {
>   ...
> }
>
Agreed, will do.

Cheers,
Prabhakar