MIME-Version: 1.0
References: <20211224202231.31130-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <CAHp75Vda7LTR=8eUki3yXEk5ia8va2Ma6Pqgj-4v6nSphNZjow@mail.gmail.com> <CA+V-a8vj30jPdXQ8PhFuawiNab0UJdiN8D6mh=c4mNGchTFfhw@mail.gmail.com>
In-Reply-To: <CA+V-a8vj30jPdXQ8PhFuawiNab0UJdiN8D6mh=c4mNGchTFfhw@mail.gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sat, 25 Dec 2021 19:18:41 +0200
Message-ID: <CAHp75VedY-xwosQJ_KttdsTFnyTYwCTtavBOh7QU_99_3949vA@mail.gmail.com>
Subject: Re: [PATCH v3] soc: ti: smartreflex: Use platform_get_irq_optional()
 to get the interrupt
To:     "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Nishanth Menon <nm@ti.com>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Dec 25, 2021 at 7:10 PM Lad, Prabhakar
<prabhakar.csengg@gmail.com> wrote:
> On Sat, Dec 25, 2021 at 4:56 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Sat, Dec 25, 2021 at 4:08 AM Lad Prabhakar
> > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:

...

> > > +       ret = 0;
> >
> > I do not see the context, is it really necessary?
> >
> Yes the change is necessary as the probe callback returns ret on
> success, and in the below code flow there might be a case where ret
> inst set. So setting the ret here.

I can't believe this, so I have checked the code and it seems it uses
return ret at the end where it should be simply return 0. So, please,
fix it there.

-- 
With Best Regards,
Andy Shevchenko