IronPort-SDR: sAK5slvYcuIV8eHJVVhciqPXYqP9o3r87yT9Dxj/IQIwUrl9J4Pokcl93bVJ7HVKAxdm80KUFY
 CT5nZXktB9jrRm2vtWCnmNEt4NRPHbcOpeepVqotJipCXgHHi0cQUYSjACTB9AsAhZCza8dsNg
 0iXUI2HQ3dM0KPPz+FBxhKtCb4rSkIsChx7zSDzmxzayh2XRPeUwqxwzRSAxpaAyQB5ZV3tcLy
 auEyjR7YvDG2xdFhwGgD7sfzRTjIdGWE7gOZTXcIUOAQCmM0Qt/ocrZsUivCseoUG9OMjUu8Wc
 IlUeBNn/0pV/tGh+1rmqq72U
IronPort-SDR: 0xvvTudFOvCnoxZ7kwKYFjK/pd1sgzFS1poahf0kqnyg6tBNxZyjhcHCk3wAy7GpX4zx1w3gVT
 AVctY8nlbi6EvcCjdHCNM6FyxvRHGz9WLA/eS5GkwiSnrUWHKxd6pXhURx1z1XX7u+9ftsvDma
 +xRnfd09iqnCGr+0NHmbkIwKsV5+JikkgFYfaI9G7xl9PsuwJTx+XZHmbRSA/juEhfQ530S6HM
 k537d3uLc0GW0t+vVby3/GOIOnVAq1gGGMuH8nI5ymFm9aNIrFi+ueYTSqf2ckVYcqJKcN4I90
 GP0=
WDCIronportException: Internal
Message-ID: <3cab75b6-f8f8-318b-4aca-b7bac484b60b@opensource.wdc.com>
Date:   Sun, 26 Dec 2021 20:56:35 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v3 02/10] ata: pata_platform: Drop use of unlikely() in
 pata_platform_probe
Content-Language: en-US
To:     "Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
        Sergey Shtylyov <s.shtylyov@omp.ru>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Rob Herring <robh+dt@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" 
        <linux-ide@vger.kernel.org>
References: <20211224131300.18198-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20211224131300.18198-3-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <a0a158e2-d77c-e3a4-5858-020674b22d92@omp.ru>
 <CA+V-a8voiYxB+s2rW9s7OhSsasvVzLO6KscO354+kaQFPO6Zsg@mail.gmail.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <CA+V-a8voiYxB+s2rW9s7OhSsasvVzLO6KscO354+kaQFPO6Zsg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/25/21 03:02, Lad, Prabhakar wrote:
> Hi Sergey,
> 
> Thank you for the review.
> 
> On Fri, Dec 24, 2021 at 5:54 PM Sergey Shtylyov <s.shtylyov@omp.ru> wrote:
>>
>> On 12/24/21 4:12 PM, Lad Prabhakar wrote:
>>
>>> pata_platform_probe() isn't a hotpath, which makes it's questionable to
>>> use unlikely(). Therefore let's simply drop it.
>>>
>>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>> ---
>>> v2-->v3
>>> * New patch
>>> ---
>>>  drivers/ata/pata_platform.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/ata/pata_platform.c b/drivers/ata/pata_platform.c
>>> index cb3134bf88eb..29902001e223 100644
>>> --- a/drivers/ata/pata_platform.c
>>> +++ b/drivers/ata/pata_platform.c
>>> @@ -199,14 +199,14 @@ static int pata_platform_probe(struct platform_device *pdev)
>>>        * Get the I/O base first
>>>        */
>>>       io_res = platform_get_mem_or_io(pdev, 0);
>>> -     if (unlikely(!io_res))
>>> +     if (!io_res)
>>>               return -EINVAL;
>>>
>>>       /*
>>>        * Then the CTL base
>>>        */
>>>       ctl_res = platform_get_mem_or_io(pdev, 1);
>>> -     if (unlikely(!ctl_res))
>>> +     if (!ctl_res)
>>>               return -EINVAL;
>>
>>    I think you should combine this with patch #1.
>>
> I'd like to keep the changes separate from patch #1, as it's unrelated.

But your patch 1 adds the unlikely... So simply do not add it in patch
one and this patch is not necessary anymore.

> 
> Cheers,
> Prabhakar


-- 
Damien Le Moal
Western Digital Research