Message-ID: <3a89b2cf-33e4-7938-08e3-348b655493d7@canonical.com>
Date:   Sun, 26 Dec 2021 12:58:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH resend] uapi: fix linux/nfc.h userspace compilation errors
Content-Language: en-US
From:   Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To:     "Dmitry V. Levin" <ldv@altlinux.org>
Cc:     Arnd Bergmann <arnd@arndb.de>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20170220181613.GB11185@altlinux.org>
 <20211225234229.GA5025@altlinux.org>
 <3d0af5ae-0510-8610-dfc2-b8e5ff682959@canonical.com>
In-Reply-To: <3d0af5ae-0510-8610-dfc2-b8e5ff682959@canonical.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 26/12/2021 12:42, Krzysztof Kozlowski wrote:
> On 26/12/2021 00:42, Dmitry V. Levin wrote:
>> Replace sa_family_t with __kernel_sa_family_t to fix the following
>> linux/nfc.h userspace compilation errors:
>>
>> /usr/include/linux/nfc.h:266:2: error: unknown type name 'sa_family_t'
>>   sa_family_t sa_family;
>> /usr/include/linux/nfc.h:274:2: error: unknown type name 'sa_family_t'
>>   sa_family_t sa_family;
>>
>> Link: https://lore.kernel.org/lkml/20170220181613.GB11185@altlinux.org/
> 
> Please skip the link. There will be link added for current patch which
> leads to this discussion. There was no discussion in 2017.
> 
>> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
>> ---
>>  The patch was submitted almost 5 years ago, and I was under impression
>>  that it was applied among others of this kind, but, apparently,
>>  it's still relevant.
>>
>>  include/uapi/linux/nfc.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/uapi/linux/nfc.h b/include/uapi/linux/nfc.h
>> index f6e3c8c9c744..aadad43d943a 100644
>> --- a/include/uapi/linux/nfc.h
>> +++ b/include/uapi/linux/nfc.h
>> @@ -263,7 +263,7 @@ enum nfc_sdp_attr {
>>  #define NFC_SE_ENABLED  0x1
>>  
>>  struct sockaddr_nfc {
>> -	sa_family_t sa_family;
>> +	__kernel_sa_family_t sa_family;
> 
> include/uapi/linux/nfc.h includes linux/socket.h which defines typedef:
>   __kernel_sa_family_t    sa_family_t;
> so how exactly the build is being fixed? How to reproduce it?
> 

Ok, I see the error - when user-space does not include sys/socket.h.
Makes sense, can you resend with removed Link and with:
Fixes: 23b7869c0fd0 ("NFC: add the NFC socket raw protocol")

Fixes: d646960f7986 ("NFC: Initial LLCP support")


Best regards,
Krzysztof