From:   "Chen, Mike Ximing" <mike.ximing.chen@intel.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "pierre-louis.bossart@linux.intel.com" 
        <pierre-louis.bossart@linux.intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>
Subject: RE: [RFC PATCH v12 01/17] dlb: add skeleton for DLB driver
Thread-Topic: [RFC PATCH v12 01/17] dlb: add skeleton for DLB driver
Thread-Index: AQHX9jcKOP1y1O92CEC3pIeygh1pI6w8tNAAgACRSSCAADPkgIAABxaggAGHswCAAHiSsIAAYEmAgAWg+WA=
Date:   Mon, 27 Dec 2021 00:40:26 +0000
Message-ID: <CO1PR11MB51700B59B074DF5F0E9364ADD9429@CO1PR11MB5170.namprd11.prod.outlook.com>
References: <20211221065047.290182-1-mike.ximing.chen@intel.com>
 <20211221065047.290182-2-mike.ximing.chen@intel.com>
 <YcGkILZxGLEUVVgU@lunn.ch>
 <CO1PR11MB51705AE8B072576F31FEC18CD97C9@CO1PR11MB5170.namprd11.prod.outlook.com>
 <YcJJh9e2QCJOoEB/@lunn.ch>
 <CO1PR11MB5170C1925DFB4BFE4B7819F5D97C9@CO1PR11MB5170.namprd11.prod.outlook.com>
 <YcOYDi1s5x5gU/5w@lunn.ch>
 <CO1PR11MB5170B7667FD1C091E1946CEDD97E9@CO1PR11MB5170.namprd11.prod.outlook.com>
 <YcRN9zwkP4nw4Dh8@lunn.ch>
In-Reply-To: <YcRN9zwkP4nw4Dh8@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-reaction: no-action
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jnpneDo76B0mrYSDS2Ih6NoS4WK1sXEHPVrxq1liiTvfIkGjcwbftP77A+xY?=
 =?us-ascii?Q?pUuJ2OwqRX0DMhZ6RAiTQf2GlgcnkD4DOcPVzYYX9Hcgdr3neNcEZPerTimO?=
 =?us-ascii?Q?GVhHs3abtGjXPPoYfa1mHKAVHsstFMKAOIEFGzUnIXq5OHCZHeJA8Hf9uf6m?=
 =?us-ascii?Q?xzzUyWCoO4LT7VvDWb/DJuNjH+kcNQyrIV/gWfuRHX1AqxjnQOyLwXwHv1wZ?=
 =?us-ascii?Q?Zd/1I8mP7GvqR1f48zLWyNh1e1aOKBhkTRZdbBHCsCUvKyaiT0RrReEJayIT?=
 =?us-ascii?Q?0AnD/wUGzZeBziHeRSOKfQAJU+5/GrCHf7M+2HsWL+CF/KnXoRG/MeNfroPt?=
 =?us-ascii?Q?Yu5S8ClDpgocazjJdfuUEAzj+iW/280v3Juo0u0YuZWLeZgQ6LK98qM8rlC7?=
 =?us-ascii?Q?qfpSRwHOYYQYjZW6VqqXjSBw/3JGKir7J4uevwuWbw6qmgAWSuccxz2W9Jq3?=
 =?us-ascii?Q?UMcTTni42oVzW0UFXwzobr3TiIgkosR/WaE3fa8Sc3tEhjsPl0lz4aCl5RMw?=
 =?us-ascii?Q?SnpQbmBEND/m1FYdk/y/jMFDH40bY0PONfk/gRbxEilDqEjblqxamxZoehPv?=
 =?us-ascii?Q?EK3ILgVOapp4NQEUeFrolOAagu6mcdqQQUbZzUdklvF69/LdTgrB5zJLbKte?=
 =?us-ascii?Q?qpPqnBASJwJNPkBjr6zqOTq+lChIQE8kRKcB6rE9sKRqeh/G6TDU3VBlVs/i?=
 =?us-ascii?Q?pidaCMwW/XfYhir/bLgv8L/0atV9JAJWfwgkskcj0QbHX2EUgP7yLk1/E+vW?=
 =?us-ascii?Q?lQFbLrHjurBCqPzAHpbKL+LJ86pa1UpM+TdmbpmqM1bsfSrVZqBeZGBf0Yb6?=
 =?us-ascii?Q?mK2qS4esr+xXaK8vpxLdFnZqoBIHk8uF2kghqrvbnP761qrzaKP7BzivjTnh?=
 =?us-ascii?Q?hnV4Dfv3HUkW3CgQDOAUh2VR5b34GKbpICdm9WOpqk+vgTzsGHqArR1PSMJg?=
 =?us-ascii?Q?L/wpnsi6Rtp98TmVOEIhs8srqBwmeNEXHz1kTtdSqwSEOAksKSq/+//bdveo?=
 =?us-ascii?Q?Bz2DogvgpN4zImynQE1zWujgQfVS/ZoXhh/zNoyWAhvHDdseSZqFMKF8TFOJ?=
 =?us-ascii?Q?Q32hn6OCMIg4cehZ51Gm11SoofwNGmecmVhxSMxmcHA4Zr2e/WlKfRtMnWmU?=
 =?us-ascii?Q?go2N3qNO+nswI0OaKkD4TIt6RyrhfZDd+r39YbOMcUuUTdx9dk85krFJz5yC?=
 =?us-ascii?Q?kS8O2ZnDy6e7UJFBv9qNVUu6/D1ThxshpD7dRcNqJaISKTU7eu+PBE/YuJ+G?=
 =?us-ascii?Q?Xv74Ih48ZMY1oNBWcOqJWegewDKkT63FIxKF/hRFrSDjLVLFLadGe4XHH9JY?=
 =?us-ascii?Q?0QZEortML4S1puTsFA+hi+EJBgwng8IzFRVOn38XDuKihaiexCYJut1Bi7hi?=
 =?us-ascii?Q?v+ALdfSy1Zm5VdHe9uH0cuiq1td0Ehv01MUlQT2t5IrliyDVhiOPKP1qKkOs?=
 =?us-ascii?Q?T/ThDUre6clbxNyGoil9ZgIp5iuNA/5hAh84li/uqb7jB14obC9qISPXhC1g?=
 =?us-ascii?Q?DtuJ+scDyqefCvdQvggAa08d80gfNdD5C+R+3quHzA2r1V0WoLsx6MNfp2BL?=
 =?us-ascii?Q?rkdm+cMErR3bu44EnLrn/NHcJka5vZhEFe0z8pG+s15yWSRdPI/caOm+1Ncx?=
 =?us-ascii?Q?uWOFJ3NAUUOV0kal9vqAR8xfQlinDjor9RVTjfWEj/OupOzuA4W6lx8ms5fB?=
 =?us-ascii?Q?c6ZpIQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5170.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87faebae-b893-4821-e928-08d9c8d179b7
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Dec 2021 00:40:26.4047
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: aEXFCU+lFdMn96EYjfUB+T3N/ARPrhpfK0Z1IPUHJXLMRk4/hJx8RF1bS2BmV6m7ymm2jzzKb1J2PVuSi/k0ML5P0C4DxZ3JRttSDn8nMJU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1983
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Thursday, December 23, 2021 5:23 AM
> To: Chen, Mike Ximing <mike.ximing.chen@intel.com>
> Cc: linux-kernel@vger.kernel.org; arnd@arndb.de; gregkh@linuxfoundation.o=
rg; Williams, Dan J
> <dan.j.williams@intel.com>; pierre-louis.bossart@linux.intel.com; netdev@=
vger.kernel.org;
> davem@davemloft.net; kuba@kernel.org
> Subject: Re: [RFC PATCH v12 01/17] dlb: add skeleton for DLB driver
>=20
> On Thu, Dec 23, 2021 at 05:15:34AM +0000, Chen, Mike Ximing wrote:
> >
> >
> > > -----Original Message-----
> > > From: Andrew Lunn <andrew@lunn.ch>
> > > Sent: Wednesday, December 22, 2021 4:27 PM
> > > To: Chen, Mike Ximing <mike.ximing.chen@intel.com>
> > > Cc: linux-kernel@vger.kernel.org; arnd@arndb.de;
> > > gregkh@linuxfoundation.org; Williams, Dan J
> > > <dan.j.williams@intel.com>; pierre-louis.bossart@linux.intel.com;
> > > netdev@vger.kernel.org; davem@davemloft.net; kuba@kernel.org
> > > Subject: Re: [RFC PATCH v12 01/17] dlb: add skeleton for DLB driver
> > >
> > > > > pointing to skbufs? How are the lifetimes of skbufs managed? How
> > > > > do you get skbufs out of the NIC? Are you using XDP?
> > > >
> > > > This is not a network accelerator in the sense that it does not
> > > > have direct access to the network sockets/ports. We do not use XDP.
> > >
> > > So not using XDP is a problem. I looked at previous versions of this
> > > patch, and it is all DPDK. But DPDK is not in mainline, XDP is. In or=
der for this to be merged into
> mainline you need a mainline user of it.
> > >
> > > Maybe you should abandon mainline, and just get this driver merged in=
to the DPDK fork of Linux?
> > >
> > Hi Andrew,
> >
> > I am not sure why not using XDP is a problem. As mentioned earlier,
> > the DLB driver is not a part of network stack.
> >
> > DPDK is one of applications that can make a good use of DLB, but is
> > not the only one. We have applications that access DLB directly via
> > the kernel driver API without using DPDK.
>=20
> Cool. Please can you point at a repo for the code? As i said, we just nee=
d a userspace user, which gives us
> a good idea how the hardware is supposed to be used, how the kAPI is to b=
e used, and act as a good test
> case for when kernel modifications are made. But it needs to be pure main=
line.
>=20
> There have been a few good discussion on LWN about accelerators recently.=
 Worth reading.
>=20
We don't have a public repo for dlb yet, but you can download the dlb=20
software package at https://www.intel.com/content/www/us/en/download/686372=
/intel-dynamic-load-balancer.html.
It includes dlb kernel driver and sample user applications (for both
DPDK and non-DPDK users).

I will check out the discussion on LWN.
Thanks for the suggestion.

Mike