Subject: Re: [PATCH] arm: Show real address of stack limit in __die()
From:   He Ying <heying24@huawei.com>
To:     <rmk+kernel@armlinux.org.uk>, <arnd@arndb.de>, <ardb@kernel.org>,
        <akpm@linux-foundation.org>, <maninder1.s@samsung.com>,
        <wangkefeng.wang@huawei.com>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20211202061916.204718-1-heying24@huawei.com>
Message-ID: <3df20137-3a0e-e22b-fccb-4dc7409406ec@huawei.com>
Date:   Mon, 27 Dec 2021 09:56:47 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20211202061916.204718-1-heying24@huawei.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Ping. Any ideas about this patch?

?? 2021/12/2 14:19, He Ying д??:
> Printing real address of stack limit makes debug easier.
> And system is dying, there is no security risk to show real
> address.
>
> Signed-off-by: He Ying <heying24@huawei.com>
> ---
>   arch/arm/kernel/traps.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c
> index 195dff58bafc..7d7c86d00482 100644
> --- a/arch/arm/kernel/traps.c
> +++ b/arch/arm/kernel/traps.c
> @@ -273,7 +273,7 @@ static int __die(const char *str, int err, struct pt_regs *regs)
>   	print_modules();
>   	__show_regs(regs);
>   	__show_regs_alloc_free(regs);
> -	pr_emerg("Process %.*s (pid: %d, stack limit = 0x%p)\n",
> +	pr_emerg("Process %.*s (pid: %d, stack limit = 0x%px)\n",
>   		 TASK_COMM_LEN, tsk->comm, task_pid_nr(tsk), end_of_stack(tsk));
>   
>   	if (!user_mode(regs) || in_interrupt()) {