From:   Clark Wang <xiaoning.wang@nxp.com>
To:     miquel.raynal@bootlin.com
Cc:     conor.culhane@silvaco.com, alexandre.belloni@bootlin.com,
        linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH V5 1/8] i3c: master: svc: move module reset behind clk enable
Date:   Mon, 27 Dec 2021 15:45:22 +0800
Message-Id: <20211227074529.1660398-2-xiaoning.wang@nxp.com>
In-Reply-To: <20211227074529.1660398-1-xiaoning.wang@nxp.com>
References: <20211227074529.1660398-1-xiaoning.wang@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?auG6ID/Fqy1rfcyGK3X4WSkQocpANdrF2ayyb9dFi22le1p1R2NYQTczJu34?=
 =?us-ascii?Q?ZI39F50gPYKTgcpJR+L2T8pgEKKfHLPjweI+uZoOK1u4WTlVfODtr3K//irU?=
 =?us-ascii?Q?DGy66ukCEr3C211s0eZ6lfep7HV4JTUkXfoyvB06/Iaz3vMK07pGp3LrtxNs?=
 =?us-ascii?Q?1qs8616kj5qy60rRe/viStA6DVH0qkM76q6SyZ30N3vfUkY+1W21uLpnk/Kg?=
 =?us-ascii?Q?f252enDRhbq119zQRR/rA5XR/5GaR6L7fPVrq4sF2Nvx/yAYtLH5k+QTUfMo?=
 =?us-ascii?Q?lLNy3eznKiGvNT/SM2qqxaOviKKzaeHc72r+4mJ4vaxvWCIHgf2JRldZUY3B?=
 =?us-ascii?Q?rSOERXIyvfvYTSWgVuqe6umPG9wJyPcXiEM2r4X9Im2QEn01g8SGpdfYUfx8?=
 =?us-ascii?Q?0qRyth68yfjepSPbddoS6gJYMTSXf1Kefz+CV3k8b/eLbxIE47BOO+JIGClz?=
 =?us-ascii?Q?kEt1aXhsnFfGeQN2zAeeKdCyUS1LuKeRzQRWbLW7ARjP7P1R5uKc1np8Bksm?=
 =?us-ascii?Q?xYQxUS2lZaBrnPXb5y1c7J1jB/5fQBz6gu9o7vvRQlSXfWZ6YbsCLpwHE48x?=
 =?us-ascii?Q?J82DNIanhXA22zKwn2+o0GKr4CVwZG0WVrahZJ3QhlVf2Pg/w5EueCg5bdzS?=
 =?us-ascii?Q?LlZ9PstB5YTPCNxhTKeALPN97gQ00j3p//G1bWMuLhoeB8dKGcAhGESgSGHp?=
 =?us-ascii?Q?woZL15w9l2ehyiok9EEDHGQ4ls+zHRsVFUfq2Na6+FzyE1Dg0f2LumFNiytw?=
 =?us-ascii?Q?EAp+KlqLDWP5v//j8R14U034TdScn6YyYZAGrMSWYAmJDfUYEkRdNnym0cNK?=
 =?us-ascii?Q?gCWSRvxl1fCJFcMZ05vRHMszBFwuBzufZvnJyy7drqlPM92cV8x0BvjyopUu?=
 =?us-ascii?Q?6Xx1Gc7dfH9U2k/MPxDj0lqAnJ4OQg2saVQDcqMg/lUly62vKufK3SIUB5Ne?=
 =?us-ascii?Q?Jbye8O7VCVFiTXupUhu4+NmR0cZm6XzLh2vI3S8xMh9fobawZPVLMto1qCbG?=
 =?us-ascii?Q?T67b+nk4zDEVvcuG6adYjzFheYzP9R8RfFcnTZABES3Hbv31UCxDoPy8eN7v?=
 =?us-ascii?Q?r8oCu44INTl0ubTG5cpENdgiF0XoQf3/6PttCWrpK/l+iDohBnDiJgBOGpU7?=
 =?us-ascii?Q?PyQmhUGPFUptrHFK5GSONWGXF9J0dk5S3hMFVMNlCg0byoLKYBgkPGgiWeA0?=
 =?us-ascii?Q?jgPj9vvL7VkHfe3JtpJ11AbZ0nCl/QYVHXRutKvKnhlL8n6Wje7AdcGtEkMu?=
 =?us-ascii?Q?mvcjwrQ9uWxsz1TcYsscrzRV1xrSaDEi1uIRGiwEurBwYvdOIRCZSDX5UCiZ?=
 =?us-ascii?Q?fgHhvwp/pN92Nl6OZ+X969GfF1yqVz2H1qlo4q8D1xW4GlHUoiAevYpAJxO9?=
 =?us-ascii?Q?D74hzSrnbb21n75erM750rs3lncPI+zGaJOAGLOtj8OHe5zMQCNQCCn3m/or?=
 =?us-ascii?Q?vq1z8IfSxEgaIasniyRqMUTArdVtm2SCBv7j4suphcFSclPRVH6Z1nYL98tE?=
 =?us-ascii?Q?GO7y9APqZ3aaogbLDkobwOeEWwQMDru8dZ5hqHfw031Xta8eNXz8aWcd2Yvk?=
 =?us-ascii?Q?d1uZIyoGvXMnZCdRNQ7u9Vpqo3q1lDJhzD33rB6EQUm3hP03l+pae8eNQZE1?=
 =?us-ascii?Q?VNpe2tgYB6idAQRtSNX9TaI=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa863be0-a184-47e4-bc24-08d9c90d6384
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5631.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Dec 2021 07:49:19.3855
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GLSZyK0ni5uax0u9SfS8DWB0lPMvKo3CA1p5SUAzsiD+TT8reCJS7rhGqwmwRT2ao9lfRe/M8RQxhXQjLICvIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5629
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Reset I3C module will R/W its regs, so enable its clocks first.

Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Jun Li <jun.li@nxp.com>
---
V5:
No change.
---
 drivers/i3c/master/svc-i3c-master.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index 879e5a64acaf..c25a372f6820 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -1381,8 +1381,6 @@ static int svc_i3c_master_probe(struct platform_device *pdev)
 
 	master->dev = dev;
 
-	svc_i3c_master_reset(master);
-
 	ret = clk_prepare_enable(master->pclk);
 	if (ret)
 		return ret;
@@ -1419,6 +1417,8 @@ static int svc_i3c_master_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, master);
 
+	svc_i3c_master_reset(master);
+
 	/* Register the master */
 	ret = i3c_master_register(&master->base, &pdev->dev,
 				  &svc_i3c_master_ops, false);
-- 
2.25.1