Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED82FC433FE for ; Mon, 27 Dec 2021 08:26:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235681AbhL0I0O (ORCPT ); Mon, 27 Dec 2021 03:26:14 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:14326 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231500AbhL0I0O (ORCPT ); Mon, 27 Dec 2021 03:26:14 -0500 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BR877xB017469; Mon, 27 Dec 2021 08:26:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=1P4OBybn/39GdzCn7ldWUWLA0wcrQqE1MjWoLHMrkg0=; b=JShrQCYqED2UiAjmsPotFmp6vN1/pKdVFdUyowflsXFGKEWxpfssAitVxTNzSzFwG6A3 mdl9z0gjzPlUqDYlSYNNB9rzamPf60n01seHQc4GeHS7LijyNCcdow3Rv2Ztu977FjK4 u6gQM6Up5pPytReiyHClWs0v0Hj6q3f9a1TQLBnZJ0+g18+Cf8ReYxg4KJiLLW2qUBU4 wR/K1BDXRxNoPidbLJmqTykAMMPCcrdQv9FqXCV3Z+WQx23vn+vGmWPCeHiZ13ollpi+ DJ1NTnt0v2svv2/FOypqbJ9bKG6Bkoci3A/dtq47RvF61LnBMBDPUQO95e1/Df8hmP4S AA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3d78vns31w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Dec 2021 08:26:11 +0000 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 1BR8JMir022435; Mon, 27 Dec 2021 08:26:11 GMT Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 3d78vns31f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Dec 2021 08:26:10 +0000 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1BR8P40H015397; Mon, 27 Dec 2021 08:26:09 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma03fra.de.ibm.com with ESMTP id 3d5tx9860b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Dec 2021 08:26:09 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1BR8P5bC45023732 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Dec 2021 08:25:05 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8D4234C04E; Mon, 27 Dec 2021 08:25:05 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E88894C046; Mon, 27 Dec 2021 08:25:04 +0000 (GMT) Received: from li-e979b1cc-23ba-11b2-a85c-dfd230f6cf82 (unknown [9.171.90.67]) by d06av22.portsmouth.uk.ibm.com (Postfix) with SMTP; Mon, 27 Dec 2021 08:25:04 +0000 (GMT) Date: Mon, 27 Dec 2021 09:25:02 +0100 From: Halil Pasic To: Tony Krowiak Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, jjherne@linux.ibm.com, freude@linux.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, mjrosato@linux.ibm.com, alex.williamson@redhat.com, kwankhede@nvidia.com, fiuczy@linux.ibm.com, Halil Pasic Subject: Re: [PATCH v17 02/15] s390/vfio-ap: use new AP bus interface to search for queue devices Message-ID: <20211227092502.7ccdf37b.pasic@linux.ibm.com> In-Reply-To: <20211021152332.70455-3-akrowiak@linux.ibm.com> References: <20211021152332.70455-1-akrowiak@linux.ibm.com> <20211021152332.70455-3-akrowiak@linux.ibm.com> Organization: IBM X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 9ayZAule2koBR6YmifoYMN-MI--aWskJ X-Proofpoint-ORIG-GUID: 9t8QRUdIUPr_X-StDnU_sZugcjWetccd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2021-12-27_02,2021-12-24_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 impostorscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=973 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112270040 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Oct 2021 11:23:19 -0400 Tony Krowiak wrote: > his patch refactors the vfio_ap device driver to use the AP bus's > ap_get_qdev() function to retrieve the vfio_ap_queue struct containing > information about a queue that is bound to the vfio_ap device driver. > The bus's ap_get_qdev() function retrieves the queue device from a > hashtable keyed by APQN. This is much more efficient than looping over > the list of devices attached to the AP bus by several orders of > magnitude. > > Signed-off-by: Tony Krowiak > Reviewed-by: Halil Pasic I assume nothing changed here, and nothing significant changed around this patch (context). If I'm wrong, please tell me and I will re-evaluate. Regards, Halil