MIME-Version: 1.0
References: <20211227090917.35838-1-hbh25y@gmail.com> <87h7aus8v0.fsf@igel.home>
In-Reply-To: <87h7aus8v0.fsf@igel.home>
From:   Hangyu Hua <hbh25y@gmail.com>
Date:   Mon, 27 Dec 2021 19:52:58 +0800
Message-ID: <CAOo-nLJG71QqqD0-cJDyH0rY2VTx1eO9nHVQ5MCe8J0iiME_vw@mail.gmail.com>
Subject: Re: [PATCH] m68k/kernel: array out of bound access in process_uboot_commandline
To:     Andreas Schwab <schwab@linux-m68k.org>
Cc:     geert@linux-m68k.org, linux-m68k@lists.linux-m68k.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

But commandp[len -1] is used to add a zero-terminated. If we don't use
commandp[0]=3D0 in len =3D=3D 0,
than commandp will not have a zero-terminated. I think strings may
make some errors beacause of this.

Thanks.


Andreas Schwab <schwab@linux-m68k.org> =E4=BA=8E2021=E5=B9=B412=E6=9C=8827=
=E6=97=A5=E5=91=A8=E4=B8=80 17:19=E5=86=99=E9=81=93=EF=BC=9A
>
> On Dez 27 2021, Hangyu Hua wrote:
>
> > diff --git a/arch/m68k/kernel/uboot.c b/arch/m68k/kernel/uboot.c
> > index 928dbd33fc4a..05eca6f653b5 100644
> > --- a/arch/m68k/kernel/uboot.c
> > +++ b/arch/m68k/kernel/uboot.c
> > @@ -101,5 +101,8 @@ __init void process_uboot_commandline(char *command=
p, int size)
> >       }
> >
> >       parse_uboot_commandline(commandp, len);
> > -     commandp[len - 1] =3D 0;
> > +     if (len > 0)
> > +             commandp[len - 1] =3D 0;
> > +     else
> > +             commandp[0] =3D 0;
>
> If len =3D=3D 0 then even commandp[0] is OOB.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint =3D 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC=
1
> "And now for something completely different."