From:   Abel Vesa <abel.vesa@nxp.com>
To:     MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc:     Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>, linux-pm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Fabio Estevam <festevam@gmail.com>
Subject: [PATCH] devfreq: imx-bus: Decouple imx-bus from icc made
Date:   Mon, 27 Dec 2021 17:03:44 +0200
Message-Id: <20211227150344.3070564-1-abel.vesa@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CmftArMa/TDNaWDhK0wTCO7eUZFSw9SPTOSMgMGk6M8cq+yGCBO38c4p6X0z?=
 =?us-ascii?Q?4M1yIFw28IY8PT0xzxKt1CavPPj35e9YrV0HKIyPjXPyE2EccHYKbXnR2J6t?=
 =?us-ascii?Q?CRdzg4RohRvC3VKGgeUL/enzRAGUtylFnQPruJL/hI5RoHIybKkVj3HvyYX4?=
 =?us-ascii?Q?5E0K+Q01wqokeTWmICNxA84wGFgkXeHyERjaqrq6677LAzvppFg8tjCvyHP5?=
 =?us-ascii?Q?Uk/l/DDjxY18QWvPxso3xJszwpAXvdd3G4CPm82rkPMZHnv7R0VEMAqQWu99?=
 =?us-ascii?Q?+TWhEOm61uOSiylG0WxPh0n9KZvwdCgPcT9W1WEf1p+a8myRzaYpClRj22Mw?=
 =?us-ascii?Q?z/viuGkQfVDFy3Vbvc/w8yYhrdBji6+XRizOdXPqNMhEiVx23NQCs/SbYuMl?=
 =?us-ascii?Q?Z6l+AIYG0oytILPTCaeZeJbx5nGJdq3BOCvBmQLl6bE2rqH3ZJ1mNlVUMfJa?=
 =?us-ascii?Q?Fzv+MNqbvbrt990IkgSyHrroqt73/CGkMJ0fFF5xufR7nAnJtJrzGVcLDqiz?=
 =?us-ascii?Q?J/I21z4l8SkAu4la0//H3LHTkAFlRAs5ZbvC9ebD1sZS7mqOCJ/ygLof0NYa?=
 =?us-ascii?Q?T7vKRZF1FL3MzCYRgksgR0OrqDFL+0mTSeJe6wJKDx+TlDmmnv4lgxgBa8yJ?=
 =?us-ascii?Q?o8+29daU2lbZJc08DY3DtquxsFhlE1HTSngOH+fSoY0rQaSMAS+QyQk19LOC?=
 =?us-ascii?Q?yFnOtSUogUCXg7Vk/p+ifECHKISaEaVPm/pHxGhGjIoM73FtJWnl6Gfc88du?=
 =?us-ascii?Q?+HyHa7pmcvvYMIG6bsohS0DgK3oRhxbV89/g5Aa3BIV4AOoh+ikSMBGTAk7f?=
 =?us-ascii?Q?NL9Lx4eRhbO6L9+FPXTRdI99jbGYFwK9WgrtHqR+UNca26M2HmbMbQZqYKyo?=
 =?us-ascii?Q?yAYGu0pBU1M6+/gyFVe6nj6v8HHNIKFSJh/5Pf6SAA5Jh3qqOaxvKGWYN+H4?=
 =?us-ascii?Q?LqAUtXh7ncrB9tEHWoizkxMS0LWRZGEainWaLB+IqJAfeoRzwnrueFTpVFkF?=
 =?us-ascii?Q?8lrZej/YEJRYr4iK8TNHgx2wt/SbWMup4cevgx+pK00OW5uzEgfcwkqFfihe?=
 =?us-ascii?Q?I0F3f21rRP9cJqYRQVr7e3UwcSXpOxrmtbGLYgpTp/VRI17DaUT4Er+Q8eEQ?=
 =?us-ascii?Q?2zKFGDLZb+5lOi0Db4l//WoQ9KdUEJi4hOMLckdmtz6Hkx0knoC02YKK6MNn?=
 =?us-ascii?Q?k9xQC6vP3Xz8t66qGK1L1V92cz8PI0dqfrtVDTM4RsRZa4ceppusmwVIGTKu?=
 =?us-ascii?Q?5WQDhvEweN6AW62KRedLEh/eqVOs3wuKtblt1lqLVwNza0FtIJNLAj7B4eau?=
 =?us-ascii?Q?2/m9145e9kEMTwu9MWWhywEbK/g7RP1U69/9vqZcElXCji61X0iZZ5u5z4Ew?=
 =?us-ascii?Q?cEkwXTd/idBFNYJZrGTYDTcM75E8YUMfxSLDTcvCnixJFeqS7ozMz0Hawv0w?=
 =?us-ascii?Q?LcQDB9YTqnP5dcQDjM4L1ISKleVJWCMfvPeMFJX0MNrHOqIQrtS6oHBjR+RX?=
 =?us-ascii?Q?jnO2LmKCzSrzlOHKw7EiI8PaAzU7ax17kZ5e8cBmJV46IcbWK/1eLUchWZx5?=
 =?us-ascii?Q?u5ZDbzB7TELCkls4EOsLcVqPZG2ObvScBwblpnukvvoMUuQbli25iXoSWi4t?=
 =?us-ascii?Q?K3Fd2TbDFnD+tZvll2uQAOQ=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c33727ab-95ac-41f7-53ac-08d9c94a1862
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4688.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Dec 2021 15:03:52.5414
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wv7rVi9y2oUSXl5fLehCDoTy2ij+193e2mbKhdX+FqhobOhZ9yOgjaN08LDdO8op4nhswdnVTBdyH6MLBk9fTw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3711
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The link between an imx-bus device and its icc id will be done
through the fsl,icc-id property in each dts node. The imx
interconnect driver will pick up all the dts nodes that have that
property defined and will link them to the rightfull icc id.

Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
---

This is part of the following patchset:
https://lore.kernel.org/lkml/1631554694-9599-1-git-send-email-abel.vesa@nxp.com/

 drivers/devfreq/imx-bus.c | 40 +++------------------------------------
 1 file changed, 3 insertions(+), 37 deletions(-)

diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c
index 9d8dc9824d21..95339de8cccf 100644
--- a/drivers/devfreq/imx-bus.c
+++ b/drivers/devfreq/imx-bus.c
@@ -53,36 +53,6 @@ static void imx_bus_exit(struct device *dev)
 	platform_device_unregister(priv->icc_pdev);
 }
 
-/* imx_bus_init_icc() - register matching icc provider if required */
-static int imx_bus_init_icc(struct device *dev)
-{
-	struct imx_bus *priv = dev_get_drvdata(dev);
-	const char *icc_driver_name;
-
-	if (!of_get_property(dev->of_node, "#interconnect-cells", 0))
-		return 0;
-	if (!IS_ENABLED(CONFIG_INTERCONNECT_IMX)) {
-		dev_warn(dev, "imx interconnect drivers disabled\n");
-		return 0;
-	}
-
-	icc_driver_name = of_device_get_match_data(dev);
-	if (!icc_driver_name) {
-		dev_err(dev, "unknown interconnect driver\n");
-		return 0;
-	}
-
-	priv->icc_pdev = platform_device_register_data(
-			dev, icc_driver_name, -1, NULL, 0);
-	if (IS_ERR(priv->icc_pdev)) {
-		dev_err(dev, "failed to register icc provider %s: %ld\n",
-				icc_driver_name, PTR_ERR(priv->icc_pdev));
-		return PTR_ERR(priv->icc_pdev);
-	}
-
-	return 0;
-}
-
 static int imx_bus_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
@@ -130,10 +100,6 @@ static int imx_bus_probe(struct platform_device *pdev)
 		goto err;
 	}
 
-	ret = imx_bus_init_icc(dev);
-	if (ret)
-		goto err;
-
 	return 0;
 
 err:
@@ -142,9 +108,9 @@ static int imx_bus_probe(struct platform_device *pdev)
 }
 
 static const struct of_device_id imx_bus_of_match[] = {
-	{ .compatible = "fsl,imx8mq-noc", .data = "imx8mq-interconnect", },
-	{ .compatible = "fsl,imx8mm-noc", .data = "imx8mm-interconnect", },
-	{ .compatible = "fsl,imx8mn-noc", .data = "imx8mn-interconnect", },
+	{ .compatible = "fsl,imx8mq-noc",},
+	{ .compatible = "fsl,imx8mm-noc",},
+	{ .compatible = "fsl,imx8mn-noc",},
 	{ .compatible = "fsl,imx8m-noc", },
 	{ .compatible = "fsl,imx8m-nic", },
 	{ /* sentinel */ },
-- 
2.31.1