Message-ID: <671aa7f6-7dd2-792c-73bf-a8092f9e7910@gmail.com>
Date:   Mon, 27 Dec 2021 20:42:52 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] staging: rtl8192e: rtllib_module: add free for error exit
Content-Language: en-US
To:     Peiwei Hu <jlu.hpw@foxmail.com>, gregkh@linuxfoundation.org
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        trivial@kernel.org
References: <tencent_D7DF0257121D1A21F136595372ED101BA10A@qq.com>
From:   Pavel Skripkin <paskripkin@gmail.com>
In-Reply-To: <tencent_D7DF0257121D1A21F136595372ED101BA10A@qq.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/27/21 11:07, Peiwei Hu wrote:
> Original source code of alloc_rtllib returns directly in
> error, without freeing variable dev.
> 
> Signed-off-by: Peiwei Hu <jlu.hpw@foxmail.com>
> ---
>   drivers/staging/rtl8192e/rtllib_module.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_module.c b/drivers/staging/rtl8192e/rtllib_module.c
> index 64d9feee1f39..18d898714c5c 100644
> --- a/drivers/staging/rtl8192e/rtllib_module.c
> +++ b/drivers/staging/rtl8192e/rtllib_module.c
> @@ -125,7 +125,7 @@ struct net_device *alloc_rtllib(int sizeof_priv)
>   
>   	ieee->pHTInfo = kzalloc(sizeof(struct rt_hi_throughput), GFP_KERNEL);
>   	if (!ieee->pHTInfo)
> -		return NULL;
> +		goto failed;
>   
>   	HTUpdateDefaultSetting(ieee);
>   	HTInitializeHTInfo(ieee);


This one is already fixed in staging-testing branch. See commit 
e730cd57ac2dfe94bca0f14a3be8e1b21de41a9c


With regards,
Pavel Skripkin