MIME-Version: 1.0
References: <20211226111614.30181-1-jose.exposito89@gmail.com>
In-Reply-To: <20211226111614.30181-1-jose.exposito89@gmail.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 27 Dec 2021 12:57:19 -0500
Message-ID: <CADnq5_N9b_Wm2GrLfL9Ug4rXN4Wqqv6kM+KxGf+kguoj6Wfytw@mail.gmail.com>
Subject: Re: [PATCH v2] drm/amd/display: fix dereference before NULL check
To:     =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>
Cc:     "Wentland, Harry" <harry.wentland@amd.com>,
        Charlene Liu <charlene.liu@amd.com>,
        "Leo (Sunpeng) Li" <sunpeng.li@amd.com>,
        xinhui pan <Xinhui.Pan@amd.com>,
        "Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
        LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Dave Airlie <airlied@linux.ie>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        "Deucher, Alexander" <alexander.deucher@amd.com>,
        Christian Koenig <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

Alex

On Sun, Dec 26, 2021 at 6:16 AM Jos=C3=A9 Exp=C3=B3sito <jose.exposito89@gm=
ail.com> wrote:
>
> The "plane_state" pointer was access before checking if it was NULL.
>
> Avoid a possible NULL pointer dereference by accessing the plane
> address after the check.
>
> Addresses-Coverity-ID: 1493892 ("Dereference before null check")
> Fixes: 3f68c01be9a22 ("drm/amd/display: add cyan_skillfish display suppor=
t")
> Signed-off-by: Jos=C3=A9 Exp=C3=B3sito <jose.exposito89@gmail.com>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> ---
>
> v2:
>
>  - Fix coverity report ID
>
>  - Add Reviewed-by tag (thanks to Harry Wentland)
> ---
>  drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c b/drive=
rs/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> index cfd09b3f705e..fe22530242d2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> @@ -134,11 +134,12 @@ void dcn201_update_plane_addr(const struct dc *dc, =
struct pipe_ctx *pipe_ctx)
>         PHYSICAL_ADDRESS_LOC addr;
>         struct dc_plane_state *plane_state =3D pipe_ctx->plane_state;
>         struct dce_hwseq *hws =3D dc->hwseq;
> -       struct dc_plane_address uma =3D plane_state->address;
> +       struct dc_plane_address uma;
>
>         if (plane_state =3D=3D NULL)
>                 return;
>
> +       uma =3D plane_state->address;
>         addr_patched =3D patch_address_for_sbs_tb_stereo(pipe_ctx, &addr)=
;
>
>         plane_address_in_gpu_space_to_uma(hws, &uma);
> --
> 2.25.1
>