Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97A40C433FE for ; Mon, 27 Dec 2021 19:58:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232571AbhL0T6J (ORCPT ); Mon, 27 Dec 2021 14:58:09 -0500 Received: from mxout04.lancloud.ru ([45.84.86.114]:40760 "EHLO mxout04.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230053AbhL0T6I (ORCPT ); Mon, 27 Dec 2021 14:58:08 -0500 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout04.lancloud.ru C16D4209AD71 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH v3 04/10] ata: pata_platform: Use platform_get_irq_optional() to get the interrupt To: Lad Prabhakar , Damien Le Moal CC: Rob Herring , , Prabhakar , References: <20211224131300.18198-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211224131300.18198-5-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <25bf8893-7369-954e-bd5b-f3d592af5b09@omp.ru> Date: Mon, 27 Dec 2021 22:58:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20211224131300.18198-5-prabhakar.mahadev-lad.rj@bp.renesas.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/24/21 4:12 PM, Lad Prabhakar wrote: > To be consistent with pata_of_platform driver use > platform_get_irq_optional() instead of > platform_get_resource(pdev, IORESOURCE_IRQ, 0). But why can't we be consistent with the unpatched pata_of_platfrom(), and then convert to platform_get_irq_optional() after merging both drivers? I'd like to avoid patching the driver to be gone if possible... > Signed-off-by: Lad Prabhakar [...] MBR, Sergey