Subject: Re: [PATCH v3 07/10] ata: pata_platform: Merge pata_of_platform into
 pata_platform
From:   Sergey Shtylyov <s.shtylyov@omp.ru>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
CC:     Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Rob Herring <robh+dt@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Prabhakar <prabhakar.csengg@gmail.com>,
        <linux-ide@vger.kernel.org>
References: <20211224131300.18198-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20211224131300.18198-8-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <CAHp75VcgknapFkZx5YhNhUgaHKGHBXdeTZ+pBcP_G9wnwfFSnw@mail.gmail.com>
 <a0f90ec0-b49a-de0d-b8f5-0443cb904847@omp.ru>
Organization: Open Mobile Platform
Message-ID: <73042c85-c194-e1c8-296c-6d9322624d83@omp.ru>
Date:   Mon, 27 Dec 2021 23:55:50 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <a0f90ec0-b49a-de0d-b8f5-0443cb904847@omp.ru>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/27/21 11:54 PM, Sergey Shtylyov wrote:

[...]
>> ...
>>
>>> +       if ((pdev->num_resources != 3) && (pdev->num_resources != 2)) {
>>> +               dev_err(&pdev->dev, "invalid number of resources\n");
>>> +               return -EINVAL;
>>
>> return dev_err_probe(); ?
>>
>>> +       }
>>
>> ...
>>
>>> +       if (!dev_of_node(&pdev->dev))
>>> +               ret = pata_platform_get_pdata(pdev, priv);
>>> +       else
>>> +               ret = pata_of_platform_get_pdata(pdev, priv);
>>
>> What the difference between them?
> 
>    One parses DT props into the private structure, the other inits this structure without DT...
> 
>> Can't you unify them and leave only
>> DT related part separately?
> 
>    He can't -- grep *defconfig for PATA_PLATFORM=, please.

   I take it back -- I think I misunderstood. :-)

> [...]

MBR, Sergey