From:   Yevhen Orlov <yevhen.orlov@plvision.eu>
To:     netdev@vger.kernel.org, stephen@networkplumber.org, andrew@lunn.ch
Cc:     Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        Yevhen Orlov <yevhen.orlov@plvision.eu>,
        Taras Chornyi <tchornyi@marvell.com>,
        Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org
Subject: [PATCH net-next v2 5/6] net: marvell: prestera: Register inetaddr stub notifiers
Date:   Mon, 27 Dec 2021 23:52:30 +0200
Message-Id: <20211227215233.31220-6-yevhen.orlov@plvision.eu>
In-Reply-To: <20211227215233.31220-1-yevhen.orlov@plvision.eu>
References: <20211227215233.31220-1-yevhen.orlov@plvision.eu>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZpicXCGOUU64KFsldb8emSaO1dehvoex3npuFL6YqtyRSJT0ivDkJAxZU4M3?=
 =?us-ascii?Q?OXaQELQZq8AVxf2eGzOspGuRJkTqttu9B8flCFJ6Ee1vMAZsOyVpFmfonBvA?=
 =?us-ascii?Q?fdhskAU1YmkXLFN59WjorI/0aZ8QO1H0E45ERtdp6cIhPSfwQOvU75uTbTNu?=
 =?us-ascii?Q?pVFUM57OpditjyrnUF8Ui12E4rVYk51n1LggW5OFpZiqWWmtbphzMLumNlDu?=
 =?us-ascii?Q?dP7h4a+sVUlXBmfixZlZkfXpVvyK2U8ZSecOEKFhA8wHWbr/7ZKdFe1Wn/Im?=
 =?us-ascii?Q?B1BYvJY++UnRjazLDs26wcpIQ72MNAXF2D3KY5zep/BUhpKp8TprtwghN8gc?=
 =?us-ascii?Q?LlfXg++nwY/nO/TLtSkUjlJFM+/juPesVVTQxLLpdwi62Z4bwzOY19jx38ZK?=
 =?us-ascii?Q?Int5Dac4wNcD6t/VQ1XEBw6zeNFyvNHbuLycolbuKVwpWyRByxrIcYSt3wh8?=
 =?us-ascii?Q?jtRBasj5k5wbujknGErXvEoo0ZpdnYqO4SaQWFdeLBf4BnfNKVPph9RzVn/Y?=
 =?us-ascii?Q?HD4b/0i1q1wZy+ll/ZR0pRT6UbREVJ5iExfSVs+V//MDjA+n707KdyszNrbL?=
 =?us-ascii?Q?V8Klrb7+z2srUW145V2KbibE8XS2jfqmNDsWowXNbPvvEMFfYJ0CUY+o75fI?=
 =?us-ascii?Q?hVTI8gkWpDORzHik/s9NkF9xy5WewkPFZ6fnqCma+9n8iTTNbidmzfY64KLG?=
 =?us-ascii?Q?UNOMUbrrkdiBJoNIyosEMtEcpzNHhmynkeWjQuzqM/qAr1E+ks0UyWEoi/ni?=
 =?us-ascii?Q?D/vlzLcYg0VB14Drmdo4xOp+W0Si8XvIASixBAmODevmN4DyqM1LWdw1vutK?=
 =?us-ascii?Q?8Kv4W9n+L3vFyBur3oTJ6LCkx/irgD0icm+cMOVVfadQb1WqnsttVfhMH7tA?=
 =?us-ascii?Q?/lCDLpWYMBp5MtpvhVRaOpGPrw+UVFfQIJz/E7hEvU5bJSiIqI+xIe3X3sWl?=
 =?us-ascii?Q?IGREpvQkQP3AWyIqBWs23n1ae9YpKVpwKVpEI9afXzNcOT/+1jXV0BiuEYHs?=
 =?us-ascii?Q?p3ptY8hMhddhy+NzYufWY41p//Ht3ybtEgxZ0FeC0UywkLMnIIU+f3JFESeJ?=
 =?us-ascii?Q?x1hk141FcX9mgkFAaAwZefYdJKph/tF8aA0N2wdTdrND/u0ZZeyYjd2hZCJ+?=
 =?us-ascii?Q?Y1oHLtTIpU+zetEvgl1V4ejs4XPUyHlKV+bSZgpB0+chRxLgofPObiOWJ5Vy?=
 =?us-ascii?Q?gPIcE6bjlZfbMzLrParNlr8XuieVErkeFP4jX+DLy+qDQw9ZkynkSF36baNv?=
 =?us-ascii?Q?jO3e+CLH4GwYPY073jBAHxbDoQzNrEIhLLZkZy/u3crIjWn1B3uEAcNYwOzL?=
 =?us-ascii?Q?Flc8qfDeQ85XQW6nD9e4Nxlh0Pb8sQFFxsMj7nzVQIlIe6sscgY2GBL7OdiJ?=
 =?us-ascii?Q?W70o4kI/HDYcTuk8ZFo/IJyA33Gq4sVcOBg6Yvjz88fpcVys3QXQxlijSCNz?=
 =?us-ascii?Q?6+0Z9yflAnpeRtK7JQpUjnRUXvy248IP+PPEG/IvU1PvzxTbI3hW+ojSCSZH?=
 =?us-ascii?Q?cVDkU8WFQV9MYVNTAbjOP60mN35BQ/s7Y2IlHjvPvNko2+xgXJlsoLfK+bvN?=
 =?us-ascii?Q?tQ3h+fGHcUph952CTGKZzs/sIgIvDzILG0Z76VWo32EXnSBgT8TfnSeWz7gV?=
 =?us-ascii?Q?uTo8O2BGPyrpKZ5f9A5Y6IXv9Ik2W675eZVAnoresqTjF4yK6c0fQptE/OgS?=
 =?us-ascii?Q?3+R4oA=3D=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: a9ca4952-1c64-407d-f4a7-08d9c98362da
X-MS-Exchange-CrossTenant-AuthSource: AM9P190MB1122.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Dec 2021 21:53:58.7301
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PZnt5sR753p9m+BprCpRziwWUb315NhGOr7qIrW8iObhuhtHoOWoq1fJPfHtx5sm9lihMXomToALKcdzoIP+8RcPvkgsJ446JoRyY7nMsIw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4P190MB0145
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Initial implementation of notification handlers. For now this is just
stub.
So that we can move forward and add prestera_router_hw's objects
manipulations.

We support several addresses on interface. We just have nothing to do for
second address, because rif is already enabled on this interface, after
first one.

Co-developed-by: Taras Chornyi <tchornyi@marvell.com>
Signed-off-by: Taras Chornyi <tchornyi@marvell.com>
Co-developed-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Signed-off-by: Yevhen Orlov <yevhen.orlov@plvision.eu>
---
v1-->v2
* Update commit message: explanation about addresses on rif
---
 .../net/ethernet/marvell/prestera/prestera.h  |   4 +
 .../ethernet/marvell/prestera/prestera_main.c |   2 +-
 .../marvell/prestera/prestera_router.c        | 105 ++++++++++++++++++
 3 files changed, 110 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera.h b/drivers/net/ethernet/marvell/prestera/prestera.h
index 7160da678457..a0a5a8e6bd8c 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera.h
+++ b/drivers/net/ethernet/marvell/prestera/prestera.h
@@ -281,6 +281,8 @@ struct prestera_router {
 	struct prestera_switch *sw;
 	struct list_head vr_list;
 	struct list_head rif_entry_list;
+	struct notifier_block inetaddr_nb;
+	struct notifier_block inetaddr_valid_nb;
 	bool aborted;
 };
 
@@ -328,6 +330,8 @@ int prestera_port_pvid_set(struct prestera_port *port, u16 vid);
 
 bool prestera_netdev_check(const struct net_device *dev);
 
+int prestera_is_valid_mac_addr(struct prestera_port *port, const u8 *addr);
+
 bool prestera_port_is_lag_member(const struct prestera_port *port);
 
 struct prestera_lag *prestera_lag_by_id(struct prestera_switch *sw, u16 id);
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
index 242904fcd866..5e45a4cda8cc 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
@@ -159,7 +159,7 @@ static netdev_tx_t prestera_port_xmit(struct sk_buff *skb,
 	return prestera_rxtx_xmit(netdev_priv(dev), skb);
 }
 
-static int prestera_is_valid_mac_addr(struct prestera_port *port, u8 *addr)
+int prestera_is_valid_mac_addr(struct prestera_port *port, const u8 *addr)
 {
 	if (!is_valid_ether_addr(addr))
 		return -EADDRNOTAVAIL;
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_router.c b/drivers/net/ethernet/marvell/prestera/prestera_router.c
index 2a32831df40f..0eb5f5e00e4e 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_router.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_router.c
@@ -3,10 +3,98 @@
 
 #include <linux/kernel.h>
 #include <linux/types.h>
+#include <linux/inetdevice.h>
 
 #include "prestera.h"
 #include "prestera_router_hw.h"
 
+static int __prestera_inetaddr_port_event(struct net_device *port_dev,
+					  unsigned long event,
+					  struct netlink_ext_ack *extack)
+{
+	struct prestera_port *port = netdev_priv(port_dev);
+	int err;
+
+	err = prestera_is_valid_mac_addr(port, port_dev->dev_addr);
+	if (err) {
+		NL_SET_ERR_MSG_MOD(extack, "RIF MAC must have the same prefix");
+		return err;
+	}
+
+	switch (event) {
+	case NETDEV_UP:
+	case NETDEV_DOWN:
+		break;
+	}
+
+	return 0;
+}
+
+static int __prestera_inetaddr_event(struct prestera_switch *sw,
+				     struct net_device *dev,
+				     unsigned long event,
+				     struct netlink_ext_ack *extack)
+{
+	if (prestera_netdev_check(dev) && !netif_is_bridge_port(dev) &&
+	    !netif_is_lag_port(dev) && !netif_is_ovs_port(dev))
+		return __prestera_inetaddr_port_event(dev, event, extack);
+
+	return 0;
+}
+
+static int __prestera_inetaddr_cb(struct notifier_block *nb,
+				  unsigned long event, void *ptr)
+{
+	struct in_ifaddr *ifa = (struct in_ifaddr *)ptr;
+	struct net_device *dev = ifa->ifa_dev->dev;
+	struct prestera_router *router = container_of(nb,
+						      struct prestera_router,
+						      inetaddr_nb);
+	struct in_device *idev;
+	int err = 0;
+
+	if (event != NETDEV_DOWN)
+		goto out;
+
+	/* Ignore if this is not latest address */
+	idev = __in_dev_get_rtnl(dev);
+	if (idev && idev->ifa_list)
+		goto out;
+
+	err = __prestera_inetaddr_event(router->sw, dev, event, NULL);
+out:
+	return notifier_from_errno(err);
+}
+
+static int __prestera_inetaddr_valid_cb(struct notifier_block *nb,
+					unsigned long event, void *ptr)
+{
+	struct in_validator_info *ivi = (struct in_validator_info *)ptr;
+	struct net_device *dev = ivi->ivi_dev->dev;
+	struct prestera_router *router = container_of(nb,
+						      struct prestera_router,
+						      inetaddr_valid_nb);
+	struct in_device *idev;
+	int err = 0;
+
+	if (event != NETDEV_UP)
+		goto out;
+
+	/* Ignore if this is not first address */
+	idev = __in_dev_get_rtnl(dev);
+	if (idev && idev->ifa_list)
+		goto out;
+
+	if (ipv4_is_multicast(ivi->ivi_addr)) {
+		err = -EINVAL;
+		goto out;
+	}
+
+	err = __prestera_inetaddr_event(router->sw, dev, event, ivi->extack);
+out:
+	return notifier_from_errno(err);
+}
+
 int prestera_router_init(struct prestera_switch *sw)
 {
 	struct prestera_router *router;
@@ -23,8 +111,22 @@ int prestera_router_init(struct prestera_switch *sw)
 	if (err)
 		goto err_router_lib_init;
 
+	router->inetaddr_valid_nb.notifier_call = __prestera_inetaddr_valid_cb;
+	err = register_inetaddr_validator_notifier(&router->inetaddr_valid_nb);
+	if (err)
+		goto err_register_inetaddr_validator_notifier;
+
+	router->inetaddr_nb.notifier_call = __prestera_inetaddr_cb;
+	err = register_inetaddr_notifier(&router->inetaddr_nb);
+	if (err)
+		goto err_register_inetaddr_notifier;
+
 	return 0;
 
+err_register_inetaddr_notifier:
+	unregister_inetaddr_validator_notifier(&router->inetaddr_valid_nb);
+err_register_inetaddr_validator_notifier:
+	/* prestera_router_hw_fini */
 err_router_lib_init:
 	kfree(sw->router);
 	return err;
@@ -32,6 +134,9 @@ int prestera_router_init(struct prestera_switch *sw)
 
 void prestera_router_fini(struct prestera_switch *sw)
 {
+	unregister_inetaddr_notifier(&sw->router->inetaddr_nb);
+	unregister_inetaddr_validator_notifier(&sw->router->inetaddr_valid_nb);
+	/* router_hw_fini */
 	kfree(sw->router);
 	sw->router = NULL;
 }
-- 
2.17.1