From:   "Brelinski, Tony" <tony.brelinski@intel.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net-next 1/9] e1000: switch to
 napi_consume_skb()
Thread-Topic: [Intel-wired-lan] [PATCH net-next 1/9] e1000: switch to
 napi_consume_skb()
Thread-Index: AQHX4I+dk+BNkj9z/EKU4Wq29BPruKxHPEqQ
Date:   Tue, 28 Dec 2021 00:06:37 +0000
Message-ID: <DM6PR11MB4218AFE1E9E4DD604693DFBC82439@DM6PR11MB4218.namprd11.prod.outlook.com>
References: <20211123171840.157471-1-alexandr.lobakin@intel.com>
 <20211123171840.157471-2-alexandr.lobakin@intel.com>
In-Reply-To: <20211123171840.157471-2-alexandr.lobakin@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.200.16
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wVzieo5TONaUJfCrb9FfrTG6/7rzBqWzx+7k24omZCQBCRKXHYv2g2+U+45s?=
 =?us-ascii?Q?IPJRJGKf9J1J283q+Xy9aZ6P5rDcpiQvgMbVykRqm5Ys3XsBDy4X2X0vgiJl?=
 =?us-ascii?Q?2qPfsirjc+8v59C5ri6/c4YtOAhIxkGbc9BQ0ep76AwPwl8HVN0SFJ04BtaN?=
 =?us-ascii?Q?oA80DDlYkYFH8H8BlfkzCqqGhzDAAVKqGPDg0WNMyunsqPaDLv+ef3WV7zXH?=
 =?us-ascii?Q?sPwaIsDEazWvF7cXGqJ9eTjTwCN7YlDYTLKAyWqoxc0CkZSjNMTFy+i6LJfi?=
 =?us-ascii?Q?y6F1e6R6QqwU6S7j0gyGuRXeRSKjxSwoWYZdHrdxzc08xde1naT8104v1m2L?=
 =?us-ascii?Q?TDS4Ab2xzuWWjuEI2s8kMgrB90yI5rSxKhv73t/wLD1Fp8YJWbbdjZUoo5tR?=
 =?us-ascii?Q?tFl/e5fqbxai9QH3PZ/4/PJvDLQk8+n9+N94nT3C6mQLRrxpZC4wbSUFeYKy?=
 =?us-ascii?Q?FVqTWkLrw/32R8GdaYnYBl9KxMa6dPlOHfJ4CMdoW5AZQHJKbfwtMADXswbk?=
 =?us-ascii?Q?9/yEwc4tm7E6mhs4+wzx/RSenUbfymgmSQRI48XfvyDn3LXOD/RBUu2x96fj?=
 =?us-ascii?Q?KHmrb8nE8GvQCmTsanwVCfFS+Y+s4+1KDw+gMy37zsR81rmGp+vqKdpC6wpw?=
 =?us-ascii?Q?fvOpCkUYp8+8dqV6t2sANNviVSOLlrXPt0xXJJuItwVHvgYrlGZXuHYbg1K8?=
 =?us-ascii?Q?JxTOKiWU5kBFjqZq6woeqXuM/Pjb3UFl4XiPQ6742nmB+YY9+rxfasAtjjRd?=
 =?us-ascii?Q?sZ79IQ94K5phjOsT22+4Z42cc0SJkNTWpg1TBQOhWgPB+AOCg1rqwxxLX3VD?=
 =?us-ascii?Q?dqqHNlTqfsIdoUwbKdF/xsXBaAtQGMK8S1qmuOQW0pIyyG87iGIN4xtHVuNg?=
 =?us-ascii?Q?gcNCz8hrAufIwykZ+Gg08i1Qee47mXkrOgZ48IZT9/0x/PE2KP9O6DcxYKNO?=
 =?us-ascii?Q?nc0tBx95MzSE0Xg+CdMClUaOtOKp3xl7h+DPlVpIkmVH3c7Az784KBiGFHjW?=
 =?us-ascii?Q?flO/rb+v6R+uf0pYUZlLMVtYwZarcqk5rEr5rv7KTZzz0cbfdKZGiXhn/rUp?=
 =?us-ascii?Q?dVjQf4Z4HGpCljUE7pg+Nc8yn7znS3/DCWP3kLQ9x/gaO29DMo2rvaHbrbzX?=
 =?us-ascii?Q?hqfEnx5I83bgu2+YnGG7CmFFvS/J29QNVsKXRC2pyRh/1Pl3OfWLv/uGNdWW?=
 =?us-ascii?Q?mVCnkPqElpMyJMOp9ZYjUDRPXXCdOtupm0HPsEwA2w4PxqCHM4YbdTTXdYgG?=
 =?us-ascii?Q?27/TY7lO7yyzCzNN8LPNGW4cz/uVYatnOmwnhWPEhfAWrRqx/OqvJhRiPWk9?=
 =?us-ascii?Q?b6i+/cZu5Sddl22itptrbf9LAazTuxLvYBBAiRotvMW9EP0DSeyg6MfP0RM1?=
 =?us-ascii?Q?+7R4T1g/63c2yVMOmx3E5QD6hY+RRV3L5Mc+vmvpHhP+czI/yisBunrkTbml?=
 =?us-ascii?Q?r1QVURq/JLfv4yh8R84R+ShRI3T6tYke3/DHbD4eWcBmCEn3tuG5LQxhcU+d?=
 =?us-ascii?Q?ceiESgsZF3WqveUfQAlG/WsUAdoi46dfiUQUSGLptR5/GJHbQCFWDWyYpxN9?=
 =?us-ascii?Q?DGzueDclBxwK9QafGTLqMVQc/0cUmqk6EXeZCAeCcfrDw4BgPdJxqItrtb0o?=
 =?us-ascii?Q?ZkyphFjHR+KI8EqFICZbToCQS0ySjI8LK1LtvcD/Cd1V3aU81keI2RFMqeTH?=
 =?us-ascii?Q?47fwww=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4218.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a511ac8a-653e-44ea-2450-08d9c995ead7
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Dec 2021 00:06:37.5754
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QaJnwSVDyPb1MYRJ5rE6WtiX0odHnUr8wU6OpzCXFq2v4vgCNHO1BFj2pXP4TT3hjd2DIgTsKTxdr/ekMhqdbwVAUlWTYGEFSyWDMw2BoCA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3706
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Alexander Lobakin
> Sent: Tuesday, November 23, 2021 9:19 AM
> To: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Jakub Kicinski
> <kuba@kernel.org>; David S. Miller <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH net-next 1/9] e1000: switch to
> napi_consume_skb()
>=20
> In order to take the best from per-cpu NAPI skbuff_head caches and CPU
> cycles, let's switch from dev_kfree_skb_any(), which passes skb back to t=
he
> mm layer, to napi_consume_skb(), which feeds those caches on non-zero
> budget instead (falls back to the former on 0).
> Do the replacement in e1000_unmap_and_free_tx_resource(). There are
> 4 call sites of this function throughout the driver:
>  * e1000_clean_tx_ring(). Slowpath, process context, cleans the
>    whole Tx ring on ifdown. Use budget of 0 here;
>  * e1000_tx_map(). Hotpath, net Tx softirq, unmaps the buffers in
>    case of error. Use 0 as well;
>  * e1000_clean_tx_irq(). Hotpath, NAPI Tx completion polling cycle.
>    As the driver doesn't count completed Tx entries towards the NAPI
>    budget, just use the poll budget of 64 to utilize caches.
>=20
> Apart from being a preparation for switching to napi_build_skb(), this is
> useful on its own as well, as napi_consume_skb() flushes skb caches by
> batches of 32 instead of one-at-a-time.
>=20
> Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> ---
>  drivers/net/ethernet/intel/e1000/e1000_main.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)

Tested-by: Tony Brelinski <tony.brelinski@intel.com>