From:   "Brelinski, Tony" <tony.brelinski@intel.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net-next 2/9] e1000: switch to
 napi_build_skb()
Thread-Topic: [Intel-wired-lan] [PATCH net-next 2/9] e1000: switch to
 napi_build_skb()
Thread-Index: AQHX4I+SpTgcDfTkF0K2NI8khtNUpKxHPI9g
Date:   Tue, 28 Dec 2021 00:07:27 +0000
Message-ID: <DM6PR11MB4218120DF7ABE8B9054023D982439@DM6PR11MB4218.namprd11.prod.outlook.com>
References: <20211123171840.157471-1-alexandr.lobakin@intel.com>
 <20211123171840.157471-3-alexandr.lobakin@intel.com>
In-Reply-To: <20211123171840.157471-3-alexandr.lobakin@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.200.16
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+UkFP4EWccIdRAU+a1uMHDlnoY2xNP4TiML3jyDXvPErwasWpGGChY82/gSx?=
 =?us-ascii?Q?cjOT7zi30bcrkYb/YvtfzAhdlJ+KLpGDJDkVZKauiQVxwXccg/cYFp7RQJOH?=
 =?us-ascii?Q?GQ9or4hCSDSXtAZCjEodySSrbSSSxteTWx0gXye1++jY3SasUYEadA4KtRYE?=
 =?us-ascii?Q?BBJEPQusMnKEIyLlm5lT2ko+ohs31L25Zvmy1rsdGBDp7WsS4CBeW6q/T9O8?=
 =?us-ascii?Q?obigQMGau1X3vFLiS29MHMyB51LR2Bg8kJXPYdC3hwLaegLDKrXdFjvC+z+q?=
 =?us-ascii?Q?z80uS1Itwx2/szupXNnLEsXdL76e6gLuhteP7cQlAPhqjDX4oUWUQbMCmMru?=
 =?us-ascii?Q?Cx1kFQyQTl8l/uUllx5BPKNMhguCbD/f2W9p8IESOYZlulA4+JHB9yrF/gnG?=
 =?us-ascii?Q?hLrmZFUjIW+AlODV821qvWDLGkpnfwa1c+J8p3Y2dMFL4NAVFSbXpw9kEhgR?=
 =?us-ascii?Q?I54VUpQnTBGBF7/ED2B/mv06oW9tHiAKBdIAMonWQlOIjmMnp2gUIQG+Ct5Y?=
 =?us-ascii?Q?Q0rfV6Av/yYJftnsCp7CM82QvtWHmOC5FXrQIqej/6TACUKUWKtNWj43IenS?=
 =?us-ascii?Q?TkqVU5MgyvD/hIQl/DosIu3Iub1D6LhcMV+T5I6+YXt3LODNR5r7IbfRLXhu?=
 =?us-ascii?Q?gOp9g2L5B3d17eJw5ovQhzXy+keNocwvulxZxGGXaBVIaV7F5aXov8WY3mtj?=
 =?us-ascii?Q?wC/l4Bx77lb8mbWFriCOsztiMF2TXILJ064is5Oz0hnN/RAuGOWIlksDVLpA?=
 =?us-ascii?Q?URBqZg8mBPLI6Fsfe+sf9ZvsaGr5WzRT4vR4049rACTnKPlc/ug7+quIGSDK?=
 =?us-ascii?Q?52igKOkwrH4NztHnu7si2vBchAb4pVaegRVMP0F+xPuBYTJngA6hlkr/KKTy?=
 =?us-ascii?Q?YHubm7LvrNY4IqFAugiOJQI97M5bu46biQXiof03JM/nm6ebreaOHXUXmqtS?=
 =?us-ascii?Q?KVJTyqZYqL66MG26jbkPCewlmtOCPMnQxbGI5iemGOKofW+KXIKPbNNpuvLC?=
 =?us-ascii?Q?UnozryZ/jIOsHxW2du4RSRQVKq5mlVDL25WjYJuckb+D2O5jcUCBimqZOjig?=
 =?us-ascii?Q?tdtnXo1JnK/ifgKiNVfwNgZno39F5I6F7MwqVr/APJwBhAI2fanRAV/KeQe7?=
 =?us-ascii?Q?Ce2dJCQm5Ob7Vi0/zwFLMc5F54iDrPg5U6771RuzPQlYqBYCsB96hsi/jegd?=
 =?us-ascii?Q?vYYUKUnhvm9oFlSLKFESvf0W7qs1t02NOnxD9mDcgzNJGIlZIezEemr3C6i9?=
 =?us-ascii?Q?XF5ZiMBNMGEGvtNbpd5QkswXmDzWwhTStf0kPRSoPGv4NPJr1EYLT7r6QTwu?=
 =?us-ascii?Q?FC8aV7jZJx2zpAsOF2/E9GyNzzr4CWVc6VjiTR9OYqdo4kr+nl74ywW2Afus?=
 =?us-ascii?Q?QTvHIJx7UviCRk+Q1FHaLXJzYbJKWrLGFchhhiioxcxYVLGKHkwwWtWIhxSm?=
 =?us-ascii?Q?tcfrlSfknzXcSdauKBn5M44RwsdsFPx42HZ0tqV1HQc3e9JSfuArqcK1FXxV?=
 =?us-ascii?Q?tbwAboI4YLIJQlhH4Bt6QkNMDHkBK8mKZIj8eFEbhjeweyXxbEmN2o0X2dwp?=
 =?us-ascii?Q?jFIuUslM8nCj7M/DAwBforoow/0jYZKDftNenMTlkKD3mASsxV2qHHXJfDNB?=
 =?us-ascii?Q?46fkEARXK/L8wEbJQLfxX5EArcljFeS4NdTlnjZgjvMu1lYk5oiMymuQwcVK?=
 =?us-ascii?Q?jZmymQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4218.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 045f88cd-3648-4123-72cc-08d9c99608a3
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Dec 2021 00:07:27.5853
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kKT7UtgNNirfv+Na7csqX+7+1FqdmnCdMqnxemKCmuCbrdKmamxDaV1d6rEbAw1xNn6xqb6m/mtk3WaerckRSapdQiJHwNqvUlCwmrtWoW0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3706
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Alexander Lobakin
> Sent: Tuesday, November 23, 2021 9:19 AM
> To: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Jakub Kicinski
> <kuba@kernel.org>; David S. Miller <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH net-next 2/9] e1000: switch to
> napi_build_skb()
>=20
> napi_build_skb() reuses per-cpu NAPI skbuff_head cache in order to save
> some cycles on freeing/allocating skbuff_heads on every new Rx or
> completed Tx element.
> e1000 driver runs Tx completion polling cycle right before the Rx one. No=
w
> that e1000 uses napi_consume_skb() to put skbuff_heads of completed
> entries into the cache, it will never empty and always warm at that momen=
t.
> Switch to the napi_build_skb() to relax mm pressure on heavy Rx and
> increase throughput.
>=20
> Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> ---
>  drivers/net/ethernet/intel/e1000/e1000_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by: Tony Brelinski <tony.brelinski@intel.com>