From:   Jia-Ju Bai <baijiaju1990@gmail.com>
To:     Larry Finger <Larry.Finger@lwfinger.net>,
        gregkh@linuxfoundation.org, zhansayabagdaulet@gmail.com,
        christophe.jaillet@wanadoo.fr, insafonov@gmail.com,
        paskripkin@gmail.com, deborahbrouwer3563@gmail.com
Cc:     linux-staging@lists.linux.dev,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: [BUG] staging: rtl8712: possible ABBA deadlocks
Message-ID: <8d695b41-74e6-4733-4841-e21fdebde890@gmail.com>
Date:   Tue, 28 Dec 2021 15:18:11 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

Hello,

My static analysis tool reports several possible ABBA deadlocks in the 
rtl8712 driver in Linux 5.10:

# BUG1:
r8712_free_all_stainfo()
   spin_lock_irqsave(&pstapriv->sta_hash_lock, irqL); --> Line 202 (Lock A)
   r8712_free_stainfo()
     r8712_free_xmitframe_queue()
       spin_lock_irqsave(&(pframequeue->lock), irqL); --> Line 834 (Lock B)

r8711_wx_set_wap()
   spin_lock_irqsave(&queue->lock, irqL); --> Line 1049 (Lock B)
   r8712_set_802_11_infrastructure_mode()
     r8712_free_assoc_resources()
       r8712_get_stainfo()
         spin_lock_irqsave(&pstapriv->sta_hash_lock, irqL); --> Line 228 
(Lock A)

When r8712_free_all_stainfo() and r8711_wx_set_wap() are concurrently 
executed, the deadlocks can occur.

# BUG2:
r8712_joinbss_event_callback()
   spin_lock_irqsave(&pstapriv->sta_hash_lock, irqL2); --> Line 735 (Lock A)
   r8712_free_stainfo()
     r8712_free_xmitframe_queue()
       spin_lock_irqsave(&(pframequeue->lock), irqL); --> Line 834 (Lock B)

r8711_wx_set_wap()
   spin_lock_irqsave(&queue->lock, irqL); --> Line 1049 (Lock B)
   r8712_set_802_11_infrastructure_mode()
     r8712_free_assoc_resources()
       r8712_get_stainfo()
         spin_lock_irqsave(&pstapriv->sta_hash_lock, irqL); --> Line 228 
(Lock A)

When r8712_joinbss_event_callback() and r8711_wx_set_wap() are 
concurrently executed, the deadlocks can occur.

# BUG3:
r8712_stadel_event_callback()
   spin_lock_irqsave(&pstapriv->sta_hash_lock, irqL); --> Line 932 (Lock A)
   r8712_free_stainfo()
     r8712_free_xmitframe_queue()
       spin_lock_irqsave(&(pframequeue->lock), irqL); --> Line 834 (Lock B)

r8711_wx_set_wap()
   spin_lock_irqsave(&queue->lock, irqL); --> Line 1049 (Lock B)
   r8712_set_802_11_infrastructure_mode()
     r8712_free_assoc_resources()
       r8712_get_stainfo()
         spin_lock_irqsave(&pstapriv->sta_hash_lock, irqL); --> Line 228 
(Lock A)

When r8712_stadel_event_callback() and r8711_wx_set_wap() are 
concurrently executed, the deadlocks can occur.


I am not quite sure whether these possible deadlocks are real and how to 
fix them if them are real.
Any feedback would be appreciated, thanks :)

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>


Best wishes,
Jia-Ju Bai