Date:   Tue, 28 Dec 2021 11:08:07 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Wedson Almeida Filho <wedsonaf@google.com>
Cc:     linux-kernel@vger.kernel.org,
        "Rafael J . Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH] kobject: remove kset from struct kset_uevent_ops
 callbacks
Message-ID: <YcriB2fJM2O5NQIZ@kroah.com>
References: <20211227163924.3970661-1-gregkh@linuxfoundation.org>
 <YcolAAn+fnXy05Cz@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YcolAAn+fnXy05Cz@google.com>
Precedence: bulk

On Mon, Dec 27, 2021 at 08:41:36PM +0000, Wedson Almeida Filho wrote:
> On Mon, Dec 27, 2021 at 05:39:24PM +0100, Greg Kroah-Hartman wrote:
> > There is no need to pass the pointer to the kset in the struct
> > kset_uevent_ops callbacks as no one uses it, so just remove that pointer
> > entirely.
> 
> In the future, if someone needs the kset they can always find it by looking for
> the first non-null kset in the kobject or its parent chain, right? IOW, we're
> not losing any information by removing this.

Or even easier, we can add it back if needed :)

> > 
> > Cc: Rafael J. Wysocki <rafael@kernel.org>
> > Cc: Wedson Almeida Filho <wedsonaf@google.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Reviewed-by: Wedson Almeida Filho <wedsonaf@google.com>

Thanks for the review.

greg k-h