Date:   Tue, 28 Dec 2021 11:56:21 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc:     William Breathitt Gray <vilhelm.gray@gmail.com>,
        "Felipe Balbi (Intel)" <balbi@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Raymond Tan <raymond.tan@intel.com>, linux-iio@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v2 17/23] counter: intel-qep: Convert to new counter
 registration
Message-ID: <20211228105621.3mfrvwlkj4n5qhar@pengutronix.de>
References: <20211227094526.698714-1-u.kleine-koenig@pengutronix.de>
 <20211227094526.698714-18-u.kleine-koenig@pengutronix.de>
 <162c710f-4fa2-1cb4-e332-83e33e510e42@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="s76ubklshzglq5px"
Content-Disposition: inline
In-Reply-To: <162c710f-4fa2-1cb4-e332-83e33e510e42@linux.intel.com>
Precedence: bulk


--s76ubklshzglq5px
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 27, 2021 at 05:02:39PM +0200, Jarkko Nikula wrote:
> On 12/27/21 11:45, Uwe Kleine-K=F6nig wrote:
> > This fixes device lifetime issues where it was possible to free a live
> > struct device.
> >=20
> > Fixes: b711f687a1c1 ("counter: Add support for Intel Quadrature Encoder=
 Peripheral")
> > Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> > ---
> >   drivers/counter/intel-qep.c | 28 ++++++++++++++++------------
> >   1 file changed, 16 insertions(+), 12 deletions(-)
> >=20
> Should the Fixes tag rather be b6c50affda59 ("counter: Add character devi=
ce
> interface") instead of when each drivers were introduced? I mean was it
> possible to hit the issue before /dev/counter was introduced?

I'm not sure if there is an issue before this, but it was already wrong
before for sure. Maybe it's possible to hold a reference somehow via
sysfs?

The thought that made me tag the individual driver commits was: With the
approach used to fix the issue all drivers need to be modified and an
unconverted driver doesn't benefit from the availability of
counter_alloc() / counter_add() if it isn't used. So all trees that
include b711f687a1c1 but not "counter: intel-qep: Convert to new counter
registration" are broken (more or less exploitable). So I think the
added Fixes line is the right choice.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--s76ubklshzglq5px
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmHK7VEACgkQwfwUeK3K
7Am7uwgAijWYzC6uycCmk8uRZHAtDVQbiHIogJeBYPl41chd2R6+cJga7T+eyEiT
W0hBfnyroNAoVM4nEJd883goCMMDEzGOfLYJEJ/QiYrDbYJBbI+rV0WyJhtutICb
huLc7WrhLNNCAIOJMAT/ApHiCjB6+PRGKs+YBKRgnv3FSYUKttnEnnWpmfV0iJ7r
Mr2osLj4Sc3ijVu/Tiyg5wrHZT1Vtyfhlk8A/kiQYtNPCBDiNWVWrfb/zrbKfkSS
k2T+1I8OXwuhS7TD89YEic8wfGlAka9akvfbOUPLGs0L7zdJG5mnNMbrYQkieVXg
mPI0b0ZzaKxoai7H4jQbB+rBP4+qLQ==
=qwU+
-----END PGP SIGNATURE-----

--s76ubklshzglq5px--