Date:   Tue, 28 Dec 2021 12:06:20 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Lars-Peter Clausen <lars@metafoo.de>
Cc:     William Breathitt Gray <vilhelm.gray@gmail.com>,
        linux-iio@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Syed Nayyar Waris <syednwaris@gmail.com>
Subject: Re: [PATCH v2 15/23] counter: 104-quad-8: Convert to new counter
 registration
Message-ID: <20211228110620.ix6ytcwvijtcyknx@pengutronix.de>
References: <20211227094526.698714-1-u.kleine-koenig@pengutronix.de>
 <20211227094526.698714-16-u.kleine-koenig@pengutronix.de>
 <406d627c-5eb3-b052-6d91-e37933584ed1@metafoo.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ijj47sjw3b4p4phw"
Content-Disposition: inline
In-Reply-To: <406d627c-5eb3-b052-6d91-e37933584ed1@metafoo.de>
Precedence: bulk


--ijj47sjw3b4p4phw
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 27, 2021 at 01:19:25PM +0100, Lars-Peter Clausen wrote:
> On 12/27/21 10:45 AM, Uwe Kleine-K=F6nig wrote:
> > [...]
> > -	return devm_counter_register(dev, &priv->counter);
> > +	err =3D devm_counter_add(dev, counter);
> > +	if (err < 0)
> > +		return dev_err_probe(dev, err, "Failed to add counter\n");
> I wonder if we should put that dev_err_probe into the devm_counter_add si=
nce
> every driver wants to have it anyway.

Personally I'm not a big fan of API functions that emit an error
message. Usually the consumer knows best if a certain failing function
call is worth an error message. Look at platform_get_irq() that some
time ago got a dev_err call. The result was to introduce a
silent variant (platform_get_irq_optional()) because emitting an error
message isn't the right thing in all cases.

Also the API function probably won't call
device_set_deferred_probe_reason() and so the consumer has to care for
that anyhow (or not which makes -EPROBE_DEFER problems harder to debug).

Furthermore the consumer can emit in some cases a better error message
than the core. (Well, this doesn't apply here, but in the example of
platform_get_irq() the driver knows the irq's purpose and can call it
"TX irq" in the error message which the irq core cannot.)

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--ijj47sjw3b4p4phw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmHK76gACgkQwfwUeK3K
7AkfKAf/SsycJVBFMdkN9iVoAhttZlDwcJ/4RqRTfd4oBsaFqYJoqR/p51HZkHJ9
n0fTx940wEdIpNvT4Ot3wLaNdTT03krMPD6xQxd0IpLjXHn8mv0gqShI9ea9P8Jm
Rk4VjIk3FWGN1Dh6AJSOvjQzrSsfcislsM4pBomz9ppI4g7KIE26Zts1FzrHVbeu
A4JoMqqBXpNtV6RRgod/G44SVz9WCz/V4djtycoTEMnyk1nCXbQVrS0xIgiNWTQ0
nRUlPxzXEljSbgT86vjRlHzZdk3e1IOGGO34ydnvftDZzMbHnZYOPdNJGiiyAqgL
7NrPrdSzurGs4Vg8T6i3lvzp1SG7Tg==
=5fdN
-----END PGP SIGNATURE-----

--ijj47sjw3b4p4phw--