Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Tue, 28 Dec 2021 08:05:18 -0800
From:   Guenter Roeck <linux@roeck-us.net>
To:     Peiwei Hu <jlu.hpw@foxmail.com>
Cc:     jdelvare@suse.com, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] hwmon: add free before exiting xgene_hwmon_probe
Message-ID: <20211228160518.GA1183124@roeck-us.net>
References: <tencent_C851C0324431466CBC22D60C5C6AC4A8E808@qq.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tencent_C851C0324431466CBC22D60C5C6AC4A8E808@qq.com>
Precedence: bulk

On Tue, Dec 28, 2021 at 04:59:10PM +0800, Peiwei Hu wrote:
> do kfifo_free(&ctx->async_msg_fifo) before error exiting
> instead of returning directly.
> 

Applied, but please reference the driver in the subject line
of future patches.

Guenter

> Signed-off-by: Peiwei Hu <jlu.hpw@foxmail.com>
> ---
>  drivers/hwmon/xgene-hwmon.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/xgene-hwmon.c b/drivers/hwmon/xgene-hwmon.c
> index 30aae8642069..5cde837bfd09 100644
> --- a/drivers/hwmon/xgene-hwmon.c
> +++ b/drivers/hwmon/xgene-hwmon.c
> @@ -659,8 +659,10 @@ static int xgene_hwmon_probe(struct platform_device *pdev)
>  
>  		acpi_id = acpi_match_device(pdev->dev.driver->acpi_match_table,
>  					    &pdev->dev);
> -		if (!acpi_id)
> -			return -EINVAL;
> +		if (!acpi_id) {
> +			rc = -EINVAL;
> +			goto out_mbox_free;
> +		}
>  
>  		version = (int)acpi_id->driver_data;
>