MIME-Version: 1.0
References: <20211228144252.390554-1-gregkh@linuxfoundation.org>
In-Reply-To: <20211228144252.390554-1-gregkh@linuxfoundation.org>
From:   Ryusuke Konishi <konishi.ryusuke@gmail.com>
Date:   Wed, 29 Dec 2021 01:52:15 +0900
Message-ID: <CAKFNMona12jPJMGveSHgVDks_EYd_ZAJ_gDRLZo=exyFD3Y8+g@mail.gmail.com>
Subject: Re: [PATCH] nilfs2: use default_groups in kobj_type
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        linux-nilfs <linux-nilfs@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Dec 28, 2021 at 11:42 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> There are currently 2 ways to create a set of sysfs files for a
> kobj_type, through the default_attrs field, and the default_groups
> field.  Move the nilfs2 code to use default_groups field which has been
> the preferred way since aa30f47cf666 ("kobject: Add support for default
> attribute groups to kobj_type") so that we can soon get rid of the
> obsolete default_attrs field.
>
> Cc: Ryusuke Konishi <konishi.ryusuke@gmail.com>
> Cc: linux-nilfs@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>

Looks good to me.
Please take it through your tree for your convenience, thanks.

Ryusuke Konishi