Date:   Wed, 29 Dec 2021 02:33:11 +0300
From:   "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     "Kirill A. Shutemov" <kirill@shutemov.name>,
        Dave Hansen <dave.hansen@intel.com>,
        Tom Lendacky <thomas.lendacky@amd.com>, tglx@linutronix.de,
        mingo@redhat.com, luto@kernel.org, peterz@infradead.org,
        sathyanarayanan.kuppuswamy@linux.intel.com, aarcange@redhat.com,
        ak@linux.intel.com, dan.j.williams@intel.com, david@redhat.com,
        hpa@zytor.com, jgross@suse.com, jmattson@google.com,
        joro@8bytes.org, jpoimboe@redhat.com, knsathya@kernel.org,
        pbonzini@redhat.com, sdeep@vmware.com, seanjc@google.com,
        tony.luck@intel.com, vkuznets@redhat.com, wanpengli@tencent.com,
        x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/26] x86/tdx: Make pages shared in ioremap()
Message-ID: <20211228233311.47g673t3pqjyyxys@black.fi.intel.com>
References: <87c288d6-9bf8-5a94-a628-1e0aaa7de690@amd.com>
 <20211223171530.v73posbqizb5l3md@black.fi.intel.com>
 <f61b591b-a06c-bc29-4b9b-a5d46111fe4e@intel.com>
 <YcTTt4LXKfDO+9u3@zn.tnic>
 <20211223205604.g44kez5d7iedatfo@box.shutemov.name>
 <YcTlhp1PUfrMOelI@zn.tnic>
 <20211224110300.7zj3nc5nbbv7jobp@black.fi.intel.com>
 <YcmoucfxOF8mwox8@zn.tnic>
 <20211227141436.ahvdngnae6xnf4nl@black.fi.intel.com>
 <YctZ8gCoaLgFCClP@zn.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YctZ8gCoaLgFCClP@zn.tnic>
Precedence: bulk

On Tue, Dec 28, 2021 at 07:39:46PM +0100, Borislav Petkov wrote:
> But my point about removing the outer check is bull - you need the
> TDX/SEV checks too to figure out which mask to use.
> 
> So, reading Tom's latest email, having
> 
> 	cc_pgprot_encrypted(prot)
> 
> and
> 	cc_pgprot_decrypted(prot)
> 
> in cc_platform.c and which hide all that logic inside doesn't sound like
> a bad idea. And cc_platform.c already looks at sme_me_mask and we do
> that there for the early path so I guess that's probably halfway fine...

Okay, will go this path.

-- 
 Kirill A. Shutemov