Date:   Wed, 29 Dec 2021 01:47:45 +0200
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Tadeusz Struk <tstruk@gmail.com>
Cc:     Jason Gunthorpe <jgg@ziepe.ca>, linux-integrity@vger.kernel.org,
        stable@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] tpm: Fix error handling in async work
Message-ID: <YcuiIdorMLEjhJn6@iki.fi>
References: <20211220211700.5772-1-tstruk@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211220211700.5772-1-tstruk@gmail.com>
Precedence: bulk

On Mon, Dec 20, 2021 at 01:16:59PM -0800, Tadeusz Struk wrote:
> When an invalid (non exitsinting) handle is used in a tpm command,
> that uses the resource manager interface (/dev/tpmrm0) the resource
> manager tries to load it from its internal cache, but fails and
> returns an -EINVAL error to the caller. The existing async handler
> doesn't handle these error cases currently and the condition in the
> poll handler never returns mask with EPOLLIN set causing the userspace
> code to get stack. Make sure that error conditions also contribute
> to the poll mask so that a correct error code could passed back
> to the caller.

Can you instead describe a failure scenario? This is very cryptic.

/Jarkko