From:   Colin Foster <colin.foster@in-advantage.com>
To:     linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        UNGLinuxDriver@microchip.com,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Lars Povlsen <lars.povlsen@microchip.com>
Subject: [PATCH v1 pinctrl-next 0/1] add blink and activity functions to SGPIO
Date:   Tue, 28 Dec 2021 16:37:28 -0800
Message-Id: <20211229003729.618079-1-colin.foster@in-advantage.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bC+RsQvXfBuQR3Azc1Ev7T74dOm55j673lvS5VhyOTqkESfWPqcjwU5EyWZX?=
 =?us-ascii?Q?oLBzJG9bjWAXgIfDCStVX7Oa/jiKIoUEh1VKed9JJ+1jPoW9IkcRhbXqzLZ2?=
 =?us-ascii?Q?jFc4Sp86lDRarSqIE1+yniGDHoio5JqV4KZAph69pV1GCLA5xXZ8r+Q1FUPT?=
 =?us-ascii?Q?XE3qXXmbGdNPbRrWYAIKaVcm824ZZ+d5WqeGbIxCkhMkFH/8CgM2wMUIUJZy?=
 =?us-ascii?Q?/oZK6oDW6YSMVGmWdkOqF22c4P++CLTsFHqAo0hqPqtwHpx9drXrmgo9ZTkX?=
 =?us-ascii?Q?71XS/mUYLnjOd9/XAzisUJ9fnWOtiRofmpmLzD8RbXdJdeEzyudr7A7tBS7N?=
 =?us-ascii?Q?uiFRIPECDq5dijeXWhLIirH2QzpCyNFGWOCmvoX9Ym7WJOUMpG7trZckZClj?=
 =?us-ascii?Q?IImYS77tpQEkCrvh9YBHArp6wil1jvX48eTef30DhwlS+KJHHNz656E/iJ0t?=
 =?us-ascii?Q?uw63NHjEyYhvEr3GOI8FifRPeHP/rYqq3KbLsJg2DlSC/wWw+S44l5xY4vL8?=
 =?us-ascii?Q?AtW5nxv2BUTpyoRvrIhnLRTAwBiX7qsvaKfc4Nc3U5po7rCyzDi4fXtSmpWI?=
 =?us-ascii?Q?bO4ltpKsxrBy7ZTq538v7yCm/7NJyrh/BfJGL5IMX8MoegpDjnfjXqJqXt1z?=
 =?us-ascii?Q?gygO4hb0ngSIjD9/inOFH80vMkr8FticcWx660wyMNqvSz3SEw3uXsaG/P+7?=
 =?us-ascii?Q?QFtE1aGvfUYIssW/oC7LyDMJRlbTG+02ezhnMqkejlpiSm5h8I1Z2n+eEwQ1?=
 =?us-ascii?Q?OfZf6hJA/8t5+/oL1E+e7l+iEr7ALNXxiwMJlfMj/Nuh4GjjbbtK3EBA6C14?=
 =?us-ascii?Q?q30K5zxOusUjwopcH2f2m6Lf7Cx/VraWcIJzpHkBUwCg+Jkl2flVch418QY1?=
 =?us-ascii?Q?35h6Po4RbdRCg95ZSJIghLve0Pt5c1vu+BzSQC7Bewt/041Ilb/qIV/M8ZGL?=
 =?us-ascii?Q?AdAoT1Kbq7MKIX8PCUXqOF23cx6/a/1znSU7q504nO1736b9HA8I8Wgy7pi0?=
 =?us-ascii?Q?+OGH+Q2eYhRt6KYpa58wFa+yxybE5CFAcn8MMbvGanrSizI5DIaY3ECXdGCY?=
 =?us-ascii?Q?t471+e5kZbrSQ/6rVNQ3RdbAQO26eZPxch+gR6W0/GHjuAppUBLxJQU/J3nN?=
 =?us-ascii?Q?iwFCQCw19fvyO2wX5uufz3nvinsSGMdwFZuPN+h/YRULPm83chTSSgjpt0T7?=
 =?us-ascii?Q?PsFsiJM6Cjj5eO7SS3f+CORs5iok1KeJsPV1yrCpnFsu4HBUAKoksssI2U6N?=
 =?us-ascii?Q?jcR6945CvIQSaO2Swkk960SDq7jJS4tK4KYNJ+hHffnCHPl4QYUCVNhKjYPp?=
 =?us-ascii?Q?ESe7rcxP2r70GYmIVyFcOI8Y3sIHuJ61xEzVTLOCmuEZjxEgYPyY1fHbzOzv?=
 =?us-ascii?Q?OnRSOOTACZblU6p11GzUEEs5sWa7TY9+r8OPk2uIOE/S5O2vvcxQfAYEqGo1?=
 =?us-ascii?Q?iyIQL5wN2fi1wJ0hWxmy+epD8AZ3m0cJ2FdNQD1o30r8o9gsncNzYDri3Mbq?=
 =?us-ascii?Q?C88zhgbddTZpMA2WSYu5xlpbm8vbsg+hP6WSEZm2yejSUyAgylPIVeNlA1yl?=
 =?us-ascii?Q?N3nT642S5+BbXTVGe6Ex5+sO0ye5uz+C5V1sTC0/AcaGwUA9FwWT08wQht8J?=
 =?us-ascii?Q?TJXddTiexsSMSCBDaQL2xwViWFWObWRFb03BqyYKTA/eEsMowpoa58Nv453j?=
 =?us-ascii?Q?tHx5BA=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d8d1953c-82a9-40f5-3cbb-08d9ca636d9b
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2021 00:37:44.2692
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3ed563Kuyzzk2I5iPkPegx7+XKknCzopAIhJe2p2mwORRYK2r72xmpipl5xwcQowlQWeOq4NGDPiafwWknJgTYYBkenq08D+HsJDZx8UccU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4612
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Expose a debugfs / devicetree interface for Microsemi SGPIO controllers.
By writing values of 2-5, the SGPIO pins can be configured for either
automatic blinking or activity.

The implementation is modeled after the code in
/drivers/pinctrl/pinctrl-ocelot.c.

I have only tested this with currently out-of-tree patches for the
VSC7512 that I hope to get in soon. They are not needed for VSC7513 /
VSC7514, SPARX5, or LUTON - but I don't have any hardware to test.

Of note: the 7512 chip has a discrepancy between the datasheet and the
registers. The datahseet claims 20Hz blink default frequency, the
registers claim 5 Hz default frequency for BMODE_0. I override the
OCELOT registers to correct for this. I don't know if that is needed for
LUTON or SPARX, but having two blink modes at the same frequency isn't
beneficial. As such, I make the blink modes match the 5Hz / 20Hz for the
two modes.

Tested with VSC7512 by way of:
echo SGPIO_O_p1b0 {blink0,blink1,activity0,activity1} > 
/sys/kernel/debug/pinctrl/pinctrl-sgpio-pinctrl-sgpio-output/pinmux-select

LEDs blink!


Colin Foster (1):
  pinctrl: microchip-sgpio: add activity and blink functionality

 drivers/pinctrl/pinctrl-microchip-sgpio.c | 135 +++++++++++++++++++++-
 1 file changed, 130 insertions(+), 5 deletions(-)

-- 
2.25.1