Date:   Wed, 29 Dec 2021 03:29:50 +0200
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Nayna Jain <nayna@linux.ibm.com>
Cc:     linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
        dhowells@redhat.com, zohar@linux.ibm.com,
        linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org, dimitri.ledkov@canonical.com,
        seth@forshee.me, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v6 1/3] certs: export load_certificate_list() to be used
 outside certs/
Message-ID: <Ycu6Dq1Tq2cqq/Lf@iki.fi>
References: <20211223013919.206273-1-nayna@linux.ibm.com>
 <20211223013919.206273-2-nayna@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211223013919.206273-2-nayna@linux.ibm.com>
Precedence: bulk

On Wed, Dec 22, 2021 at 08:39:17PM -0500, Nayna Jain wrote:
> load_certificate_list() parses certificates embedded in the kernel
> image to load them onto the keyring.
> 
> Commit "2565ca7f5ec1 (certs: Move load_system_certificate_list to a common
> function)" made load_certificate_list() a common function in the certs/
> directory. Now, export load_certificate_list() outside certs/ to be used
> by other functions.

It is exported to make callable by load_platform_certificate_list(). Making
anything callable by other functions by itself has no inherit value, and
does not serve as a stimulus to make such code change.

/Jarkko