Date:   Wed, 29 Dec 2021 15:38:40 +0900
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc:     Lars-Peter Clausen <lars@metafoo.de>, kernel@pengutronix.de,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        linux-iio@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/23] counter: Use container_of instead of drvdata to
 track counter_device
Message-ID: <YcwCcBtdMKAvnCwM@shinobu>
References: <20211227094526.698714-1-u.kleine-koenig@pengutronix.de>
 <20211227094526.698714-2-u.kleine-koenig@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="WTvz+wxjL/4uBLQm"
Content-Disposition: inline
In-Reply-To: <20211227094526.698714-2-u.kleine-koenig@pengutronix.de>
Precedence: bulk


--WTvz+wxjL/4uBLQm
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 27, 2021 at 10:45:04AM +0100, Uwe Kleine-K=C3=B6nig wrote:
> The counter core uses drvdata to find a struct counter_device from a
> struct device. However as the device is a member of struct counter_device,
> the lookup can be done faster (and a bit type safe) using container_of.
>=20
> There are no other users of drvdata, so the call to dev_set_drvdata can
> go away, too.
>=20
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>

Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>

> ---
>  drivers/counter/counter-core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/counter/counter-core.c b/drivers/counter/counter-cor=
e.c
> index 5acc54539623..f053a43c6c04 100644
> --- a/drivers/counter/counter-core.c
> +++ b/drivers/counter/counter-core.c
> @@ -26,7 +26,8 @@ static DEFINE_IDA(counter_ida);
> =20
>  static void counter_device_release(struct device *dev)
>  {
> -	struct counter_device *const counter =3D dev_get_drvdata(dev);
> +	struct counter_device *const counter =3D
> +		container_of(dev, struct counter_device, dev);
> =20
>  	counter_chrdev_remove(counter);
>  	ida_free(&counter_ida, dev->id);
> @@ -78,7 +79,6 @@ int counter_register(struct counter_device *const count=
er)
>  		dev->of_node =3D counter->parent->of_node;
>  	}
>  	device_initialize(dev);
> -	dev_set_drvdata(dev, counter);
> =20
>  	err =3D counter_sysfs_add(counter);
>  	if (err < 0)
> --=20
> 2.33.0
>=20

--WTvz+wxjL/4uBLQm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmHMAmQACgkQhvpINdm7
VJLhoRAA1awIOpM+/ZjFSO9uo2UlhAAS47AmLL8iQsMS3jmHgxts0wXc7lpmEn+G
vm9OziM32ZjLPkuvAX4oXG8TMLn2tWv1Rzx7JPiPgwL+qZI4QCwkZMQEqNEegaFh
LabmP/dl0EwjR30qSIbAyCKdMNoPtmk8xwJmMuZ/Fu2xxIGsiekDsOhdK6dSZCkb
E3youbzkRizKcTGG+udXgDsu8i6G6CsCB7hjgpmRcaKboVPRyxet2PA3XVyElycN
wsG1FtlpOd4rebqInjqTMB3mnRslr1qAWvfzEA3eW+/KLNHWWcKnrpMb88OWwzWx
8L92mcQKrGaTYPr778+YkbrSPWFa8Noecn72JfH3E9WMC9XOqgGL6FRAmv5RVDmE
SPdt7jJ6mQ6X/JWWGKqD0RqhIjj0C2AzxFj5K3uGyvgnf/V8Qt1Fq2E6t6uFKqRI
1tJ9mxkEu6libBF6hDQrYAG25+neIxHZtYgwwgY/ytAs3Dex8DZm2CYyeavMRPzZ
Kcog+jmVZd69nweHRdUSsVRFBGJD0s5kfsOsAopT6PmCaZbDqIfLTUZdUxzyDrrJ
DH9opqkyZZyWPX5S+82u4OICg9j9AcswrZmcEW4Yx8irfyVmZRWTgQdCxRsAzj9f
4mNnOe05yVi45qCEK7sr6skxU/hsDNE9IhD8CW2Arh57yJrwvs4=
=7A2O
-----END PGP SIGNATURE-----

--WTvz+wxjL/4uBLQm--