Date:   Wed, 29 Dec 2021 15:42:32 +0900
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc:     Lars-Peter Clausen <lars@metafoo.de>, kernel@pengutronix.de,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        linux-iio@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org,
        Patrick Havelange <patrick.havelange@essensium.com>,
        Syed Nayyar Waris <syednwaris@gmail.com>
Subject: Re: [PATCH v2 02/23] counter: ftm-quaddec: Drop unused
 platform_set_drvdata()
Message-ID: <YcwDWJrEfot25Dt+@shinobu>
References: <20211227094526.698714-1-u.kleine-koenig@pengutronix.de>
 <20211227094526.698714-3-u.kleine-koenig@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="iAkbqrEutrL+NjXR"
Content-Disposition: inline
In-Reply-To: <20211227094526.698714-3-u.kleine-koenig@pengutronix.de>
Precedence: bulk


--iAkbqrEutrL+NjXR
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 27, 2021 at 10:45:05AM +0100, Uwe Kleine-K=C3=B6nig wrote:
> The driver doesn't ever use platform_get_drvdata, so drop this unused
> call.
>=20
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>

Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>

By the way, it should be possible to remove pdev from struct ftm_quaddec
because &ftm->pdev->dev is stored to ftm->counter.parent and can be
accessed from there if needed.

> ---
>  drivers/counter/ftm-quaddec.c | 2 --
>  1 file changed, 2 deletions(-)
>=20
> diff --git a/drivers/counter/ftm-quaddec.c b/drivers/counter/ftm-quaddec.c
> index 5ef0478709cd..9272f7b58beb 100644
> --- a/drivers/counter/ftm-quaddec.c
> +++ b/drivers/counter/ftm-quaddec.c
> @@ -269,8 +269,6 @@ static int ftm_quaddec_probe(struct platform_device *=
pdev)
>  	if (!ftm)
>  		return -ENOMEM;
> =20
> -	platform_set_drvdata(pdev, ftm);
> -
>  	io =3D platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	if (!io) {
>  		dev_err(&pdev->dev, "Failed to get memory region\n");
> --=20
> 2.33.0
>=20

--iAkbqrEutrL+NjXR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmHMA1cACgkQhvpINdm7
VJLzWA//aQSbn5j4o8WDb8NbzW0ZD/17/JxOr42DBlC03forlAWkKW7hrBuO8fL4
WPc5o/vSNryn+PKLlRAWBLiWskUU49/M1wzabPptph78zRmcfr/l5Vyi1EVhkx57
gfLUXmisPHgFB/ftP8FVaBi/xzE4+P9MpQ1igHMSWRddJBrWBqAWNmw79VacraGL
lP1+F/uxQIshFnDdoZa+9eV42Eq76gvlXAIS74q/yqpTDww5WlWGn9lx+OD4zH3L
Ukj9o3TF+sKmZ/dvv5IqQZQm9JSa7aVyC01EhgF1lFXgmFgAPQvY7MlitsbYOQuQ
O7jEsRgzgWwldbYkKKvc9oMZFI9M/t2tIi/jVD3HZdXM0kpJF9V//XHMnHlEbF8w
5+KDiH63kLLXrtqokTIDatQzbhabrvWCYagFMeibdZFSuGKghOohMJYifCRxSJbi
xVV6nGF4E8bKkcJUWOC78VgJLK2f1xoPi+ULZtOj0HaZ379lMy0PA60LfXvPOAwE
Tz+HbKd4NP2AweJNn1ho7eHmFvXQj/QhWO0JTPnkdchD3QUDzzgVdZaGgnIPRIkw
dXHyda8F/rgLoQ1rqF5ZZIALZh+vccc4mt+iad7wwhtrca8UYSzGObB1SQSCbB61
UwvL/UQ4b1xNmIeXAmGQB9vcDxQ4ubPKUit9EMbF7dOltL6IESo=
=NbKA
-----END PGP SIGNATURE-----

--iAkbqrEutrL+NjXR--