From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Christopherson,, Sean" <seanjc@google.com>,
        "Liu, Jing2" <jing2.liu@intel.com>
CC:     "x86@kernel.org" <x86@kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "Nakajima, Jun" <jun.nakajima@intel.com>,
        "jing2.liu@linux.intel.com" <jing2.liu@linux.intel.com>,
        "Zeng, Guang" <guang.zeng@intel.com>,
        "Wang, Wei W" <wei.w.wang@intel.com>,
        "Zhong, Yang" <yang.zhong@intel.com>
Subject: RE: [PATCH v3 13/22] kvm: x86: Intercept #NM for saving IA32_XFD_ERR
Thread-Topic: [PATCH v3 13/22] kvm: x86: Intercept #NM for saving IA32_XFD_ERR
Thread-Index: AQHX9zE1lVRiv1UsgEq40a+CF3C7OqxIomKAgAAmHcCAAEjrMA==
Date:   Wed, 29 Dec 2021 06:50:30 +0000
Message-ID: <BN9PR11MB5276E07D7D491FCD49C19CE38C449@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20211222124052.644626-1-jing2.liu@intel.com>
 <20211222124052.644626-14-jing2.liu@intel.com> <YcunSb52LlGKT7dC@google.com> 
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jZxdK/PBm1bz3j0j3icJEuT4Lpg3xtfpBuqdFfuqaqsuM8qbaF2JeBZ8Zha9?=
 =?us-ascii?Q?VRUCKkeyKxSxLxgjPhnSW4Ty4voXkPtqhJATfyrL/BQ3zKAxXYUFUoGr9nC+?=
 =?us-ascii?Q?Q9LYJLi9Th/mvZMIc01sZTXc/O5/FkMj0Nqx8YN+G1FDkPXeWn6RRMk9qwiS?=
 =?us-ascii?Q?FUkrckUD7f+RSl2zPV6pWhcYYsCb9YEAI+Ifax+spNekbIClT386/bIjOClQ?=
 =?us-ascii?Q?CIbU/7bK9cEpUtKz/X7mGa5XDHLwCR28ej3hE4lkeuigIXsxm82i4hlp1IvA?=
 =?us-ascii?Q?V+xoh9BZK70lHrojO1W/0677LjdnLIXgtoMkL/K6gDzXGUIS2PD2FNRWT39e?=
 =?us-ascii?Q?p8GRovI/tjPqVuKG6otb5mbJ32x10yuiEe/ob8oUrjwrXV3CS0WiazAarzSj?=
 =?us-ascii?Q?xDcMzTOaTI2/djA0hnO5PZYg1ad+QAGWS1ruRnvfhRtPvVPF1Uc+rN4lZA7R?=
 =?us-ascii?Q?uU54VB9XpTIJ5S6HBYYoUPvl4l7yxwe5FW531Tc6KbQY95PiZKzsHh/oOtP7?=
 =?us-ascii?Q?8zan/qzkSDO4Y4Du+LMG8Sx6P2h4EbgnZi5NAGslFZXKBVAWbXweeR9H/DlZ?=
 =?us-ascii?Q?3rpc3MMocy04tfS8qIEDXPcgyFWWGoB/Sj+4W3tCivGeoZXo+6FQfEg9xI+9?=
 =?us-ascii?Q?ZuLt2OQZU4WS/9uYnm09Wm3FOoxPICKSZOOGOwYch762dir2wlImpNGLtS3U?=
 =?us-ascii?Q?DcCo8+s0Thd+9jOkedCkw5h082JeAQOji0DbFfwY3eeUIp+qqh/3bHiX8+hC?=
 =?us-ascii?Q?WJmYMndlyPm1y4nKTKNpP9F+TjiRfgzwpukAM6GUzbA3ZAflY6s8NOFdxATg?=
 =?us-ascii?Q?Jb748ba13Ce4NFZRNhutfKGTMTz8AGtesEtDjpAE6UONSReXjb8lu3XtNMol?=
 =?us-ascii?Q?WXsASQ9FOqkyMiFaxMrrxU2ZijnkM6R0aTVK461UJYr3a3PDfJTEOPgmL3Js?=
 =?us-ascii?Q?c/nHB465uzG8N6w518D6gZYj0PCRjEsfTekhv+6fmyh8tqI5pEUOF07DGRCV?=
 =?us-ascii?Q?EcRD1acuI/FqFZTKckvF7YmslaUoMcwewW2xyupi17Xh9PJmVX6evM+TJLYc?=
 =?us-ascii?Q?md8TaWNHwiEFikP6AgoOSGVVEBr+6AcyV95BwIngkjAPK9TQxAzuGuEeFwNq?=
 =?us-ascii?Q?8NciOmxtzCltwmAjFaGt+W98rO+hTSAGRuVkDCeNefogV1KWuB5Fe3QYQPw/?=
 =?us-ascii?Q?rfFCiKItqypLOu/IO7LL1zaSaUng/Y5xpGu1HD66Hk6mCciaL4+2xSbOyjFL?=
 =?us-ascii?Q?6yZCg4HDImH+q4fcqBYU1nzLQvfcj559a8PRFV0LbQ2qpCnTIFon9kXPyyVo?=
 =?us-ascii?Q?lq86Lxx6ReU4n1BGfNV6qdJm2N/JnhXdaTYi7YaJztp3wm07W+YeDicH1rB/?=
 =?us-ascii?Q?w8vM5Pu+vNwNcpVevHjx5ZuZeMxq97LgbuzTB1FDhOPQLM+Uf1kMQ7jn3Wik?=
 =?us-ascii?Q?Bs+iA1BSvcid26eZMjWERHawXTE1Oui+wkXwMa3KbOTJP0u4521q54qMieyx?=
 =?us-ascii?Q?ONYxdEcZqx3G6EL816BZOUzQXB4gXk67hPoprSAGKWC84+VnPAfZlLnI4krS?=
 =?us-ascii?Q?abSQLnXcgUeItRf/6Ds/Mk5NoEkBEcRqkf8ftlxxOJrALOouR+gB121R8g9Z?=
 =?us-ascii?Q?OKHPObbs9PE5Ek9wqSdiLVo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: daffb3b7-7802-4c0f-5b56-08d9ca978152
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2021 06:50:30.6673
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: orz97maWIGk+VUnMeD02kjGOX4Rah4Y7+kZrUaCLxw1LdldsKfVaQvfBoKgf7tCQPwIwKkMz60dippb6Szbf7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1249
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Tian, Kevin
> Sent: Wednesday, December 29, 2021 10:53 AM
> > > +	case MSR_IA32_XFD:
> > > +		ret =3D kvm_set_msr_common(vcpu, msr_info);
> > > +		if (!ret && data) {
> > > +			vcpu->arch.trap_nm =3D true;
> > > +			vmx_update_exception_bitmap(vcpu);
> >
> > This is wrong, it fails to clear vcpu->arch.trap_nm and update the bitm=
ap if
> > the
> > MSR is cleared.
>=20
> In concept you are right if just looking at this patch. It's pointless to
> trap #NM if guest xfd is cleared.
>=20
> But here we need think about patch22 which disables write interception
> for xfd. With that in consideration we use the 1st non-zero write as the
> hint indicating that guest might enable xfd-related usages thus always
> trap #NM after this point.
>=20
> It's not a good ordering, but Paolo wants to put the optimization in the
> end of this series. But we do need to put a clear comment here explaining
> the always-trap policy.

Given write emulation of XFD is not disabled in this patch, it reads cleane=
r
to always update exception bitmap according to guest xfd value at this
stage. So we will follow your suggestion here and then change to check
msr bitmap when write emulation is disabled in patch22.

Thanks
Kevin