Message-ID: <cf6cfba0-816f-ca1e-3bb1-aad693e5a0b3@quicinc.com>
Date:   Wed, 29 Dec 2021 12:22:54 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] thermal/core: Clear all mitigation when thermal zone is
 disabled
To:     Matthias Kaehlcke <mka@chromium.org>
CC:     "Rafael J . Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Thara Gopinath <thara.gopinath@linaro.org>,
        <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1640083318-19277-1-git-send-email-quic_manafm@quicinc.com>
 <YcSNIJVnCQvx6ttg@google.com>
From:   Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com>
In-Reply-To: <YcSNIJVnCQvx6ttg@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/23/2021 8:22 PM, Matthias Kaehlcke wrote:
> On Tue, Dec 21, 2021 at 04:11:58PM +0530, Manaf Meethalavalappu Pallikunhi wrote:
>> Whenever a thermal zone is in trip violated state, there is a chance
>> that the same thermal zone mode can be disabled either via thermal
>> core API or via thermal zone sysfs. Once it is disabled, the framework
>> bails out any re-evaluation of thermal zone. It leads to a case where
>> if it is already in mitigation state, it will stay the same state
>> until it is re-enabled.
>>
>> To avoid above mentioned issue, on thermal zone disable request
>> reset thermal zone and clear mitigation for each trip explicitly.
>>
>> Signed-off-by: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com>
>> ---
>>   drivers/thermal/thermal_core.c | 9 ++++++++-
>>   1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
>> index 51374f4..a8ae340 100644
>> --- a/drivers/thermal/thermal_core.c
>> +++ b/drivers/thermal/thermal_core.c
>> @@ -427,6 +427,7 @@ static int thermal_zone_device_set_mode(struct thermal_zone_device *tz,
>>   					enum thermal_device_mode mode)
>>   {
>>   	int ret = 0;
>> +	int count;
>>   
>>   	mutex_lock(&tz->lock);
>>   
>> @@ -449,8 +450,14 @@ static int thermal_zone_device_set_mode(struct thermal_zone_device *tz,
>>   
>>   	if (mode == THERMAL_DEVICE_ENABLED)
>>   		thermal_notify_tz_enable(tz->id);
>> -	else
>> +	else {
>> +		/* make sure all previous throttlings are cleared */
>> +		thermal_zone_device_init(tz);
>> +		for (count = 0; count < tz->trips; count++)
>> +			handle_thermal_trip(tz, count);
> nit: s/count/trip/
Updated in V2