Date:   Wed, 29 Dec 2021 10:20:17 +0000
From:   Lee Jones <lee.jones@linaro.org>
To:     Caleb Connolly <caleb.connolly@linaro.org>
Cc:     David Heidelberg <david@ixit.cz>, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Stephen Boyd <sboyd@kernel.org>, ~okias/devicetree@lists.sr.ht,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        devicetree@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: mfd: convert to yaml Qualcomm SPMI PMIC
Message-ID: <Ycw2YXOhOSEPmIMd@google.com>
References: <20211227215433.114426-1-david@ixit.cz>
 <Ycwu4fMfE2LmnyOv@google.com>
 <CAC-n0Dw5eyd5=zXouLX=_3xpNY+sUphk-fwKwfGb_6=KbzFDaA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAC-n0Dw5eyd5=zXouLX=_3xpNY+sUphk-fwKwfGb_6=KbzFDaA@mail.gmail.com>
Precedence: bulk

On Wed, 29 Dec 2021, Caleb Connolly wrote:

> On Wed, 29 Dec 2021, 09:48 Lee Jones, <lee.jones@linaro.org> wrote:
> 
> > On Mon, 27 Dec 2021, David Heidelberg wrote:
> >
> > > From: Caleb Connolly <caleb.connolly@linaro.org>
> > >
> > > Convert Qualcomm SPMI PMIC binding to yaml format.
> > >
> > > Additional changes:
> > >  - filled many missing compatibles
> > >
> > > Co-developed-by: David Heidelberg <david@ixit.cz>
> > > Signed-off-by: David Heidelberg <david@ixit.cz>
> >
> > I must admit, I'm a bit hazy on the details, but this looks odd to
> > me.  Shouldn't this have Caleb's SoB too?  Also, if you apply your
> > SoB, I'm not sure you also need to apply a CDB as well?
> >
> Yeah, this should not be from me, I did originally work on this patch but
> wasn't able to finish it. David perhaps resend with yourself as the patch
> author and add
> Co-developed-by: Caleb Connolly <caleb@connolly.tech>

That would make more sense.

> (either way, it shouldn't have been authored by my @linaro.org email
> address).

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog