From:   Li Chen <lchen@ambarella.com>
To:     Kishon Vijay Abraham I <kishon@ti.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        =?iso-8859-2?Q?Krzysztof_Wilczy=F1ski?= <kw@linux.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] misc: pci_endpoint_test: fix misuse of COMMAND_READ/WRITE
Thread-Topic: [PATCH] misc: pci_endpoint_test: fix misuse of
 COMMAND_READ/WRITE
Thread-Index: Adf8ec9MVzgZ+shNToay1AX1NAaMGAAJ34Cw
Date:   Wed, 29 Dec 2021 10:49:37 +0000
Message-ID: <PH7PR19MB5562E60AFDA5416F50376924A0449@PH7PR19MB5562.namprd19.prod.outlook.com>
References: <PH7PR19MB55623C78565E9CEA2A98D237A0449@PH7PR19MB5562.namprd19.prod.outlook.com>
In-Reply-To: <PH7PR19MB55623C78565E9CEA2A98D237A0449@PH7PR19MB5562.namprd19.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?lKV2CnJ4ICgSkthQkADqXJUzT6H2wB1PI89Rq3bF2JJOeuQioXiNeI/P5s?=
 =?iso-8859-2?Q?18O9FD1txzor8yHwmsu3h5NyoE1VmYq9VRX0CsH/ee6PVQWzxVlR+RF/SQ?=
 =?iso-8859-2?Q?SPIyC4Fp6xeqKUUOJmEJJCVQKmYCerv2GYZuwIcS5C1MJ4j6KNlDRnhqDY?=
 =?iso-8859-2?Q?JK0+RbqslPFaB9D+sUkGWuK5r0pE/1+GFOyy3W0+FYObuMTa4L+hI2uABL?=
 =?iso-8859-2?Q?1qF8fEqJzCMiW3ANrrDr9yO81TFG+/YSOTAJF0ZCUYMP1JFJtocBfS4wei?=
 =?iso-8859-2?Q?M2DFiuZO6wZn0kw+BFXyxyp1lL+WG6fe/2Zc88qMGiAcOfCzIiKlIr2Qns?=
 =?iso-8859-2?Q?F1eAk/SuUEVYi5pAx1GsXKiLqFn65DsbZ/JPSfduR1h9+vuhQpnVZPo+cF?=
 =?iso-8859-2?Q?bVRE1ce8EyrbTKbHpB9sFO4oLUYIX1BUQk0legmy2OhYhI5XQPlqqFU1Gu?=
 =?iso-8859-2?Q?vyjyxHsdiFIdVuCmwVeKAZlbkqwwSn9Ox0CLYcv6aEkgiTesJrAJo96Gyo?=
 =?iso-8859-2?Q?14gvYAvxeCtR3nDhMK7vCz7LMFpZ3SgvjKrZcsCdaMfEAW9k82P7xQkGC9?=
 =?iso-8859-2?Q?Pp9YO0FBmBu2eFlc1UsFWMSjUNqW5lG8nwDwBU2uMC25DPhfsBrUkbVf9J?=
 =?iso-8859-2?Q?3RBV8mGCV/oCsxEXlns1DbWp0xjtO654yBXeFxPFTi1+UZ8W7vQUd8ej5d?=
 =?iso-8859-2?Q?cZy1jNzVheMvDpPqlk0DUu5oM3tXSkHKrdNPJmQnjrDTZhLMH5gyj1iTEl?=
 =?iso-8859-2?Q?18b/XcS/zsqnUgb1NWFLRaQ7WyG15ZbyBb0Vold7psMJIh7VdiELZdtjAZ?=
 =?iso-8859-2?Q?/qXp0oT3ljCpdaTzoo/QUqM7ShPO3ViuhtUK0+2Uuu9vlB/NvbffQE5ej1?=
 =?iso-8859-2?Q?5oN90dJzy3rzJe8h05FHbg9h0pMEbH0y822E5e7so43CrAcKfr/y3Zbqa6?=
 =?iso-8859-2?Q?syckbyWdQX/vZ1n0Q65MTNCgP45YLQKNsUnI46+MHdYv67eyl5JtVpEKEH?=
 =?iso-8859-2?Q?tilEsj5SljEgtq3ktjvsHIPSCYT2GqEr1s4GWL4LcKQXBHmwk1ypNZYNDp?=
 =?iso-8859-2?Q?BtklYY7cI8aBWPPBgPiOMxQzwewC9JZS4way0TfTZyfTGy3yXCqHttnczC?=
 =?iso-8859-2?Q?Y8rzKTedO4U31UGCBT4YE5NkSf/TtnvquAIgWenVuq9KWd2u8vLWsyItuI?=
 =?iso-8859-2?Q?vMZLs/ygtGQCQt8XgMHmwUBOtR2f2LAfFVjL031Fz9tN8i+nF0VI932yA7?=
 =?iso-8859-2?Q?o1VvGjKub01ZIazSwjBiWeHwMolxHcH8hYu8gkKWxCAI7ufDvuj5oJ7FS8?=
 =?iso-8859-2?Q?u8/Y/kPQ7XZkIXNx2MJiuwm+ufliwtuN1U6V0sAR0y6/+XFhs6Way5742Q?=
 =?iso-8859-2?Q?tO/58aO2pxpA8O2UfrJkVHZmyj+IuMGILb2KuGJnMAPFPlJDxdxVKdv7E8?=
 =?iso-8859-2?Q?sqWPqoaLm9/hJXy4vW1C5/uSNUvY2JKTSJfJEzi1qAImJ2sICi9jLfmCEq?=
 =?iso-8859-2?Q?61bfclGFsrLbC5D/P5QqfCyndF2ieLzRWfXq3On1mQEzXG6JnZyDUbxns8?=
 =?iso-8859-2?Q?7f0BzCn918SqhhpWABGIETXUfKvXTwE5jGfF/b4j7MbPPzdNPPWh+vT7kv?=
 =?iso-8859-2?Q?FbZJj/qOaQoyPiNB14GGHdnSOy6BaEHzUyEAagzZPOPWtAtF5C0u+GfO64?=
 =?iso-8859-2?Q?YlCjk3wC+QFe90ijdlY=3D?=
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: ambarella.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH7PR19MB5562.namprd19.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf9c299f-51ce-4343-0b8b-08d9cab8e900
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2021 10:49:37.9336
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3ccd3c8d-5f7c-4eb4-ae6f-32d8c106402c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0/U7APlOQNLb0+9RK70b4XgduzG8S4OGUBTG9wr4UPGweGMw6dXfwVDiS7iDMTFyQ4emsfSNLnfDcO32Id4E9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR19MB5659
X-Proofpoint-GUID: EkAoBhW5LVbYe9D3yl0X0OS0CHesgyiu
X-Proofpoint-ORIG-GUID: EkAoBhW5LVbYe9D3yl0X0OS0CHesgyiu
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-29_04,2021-12-29_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0
 adultscore=0 mlxlogscore=999 mlxscore=0 clxscore=1015 lowpriorityscore=0
 impostorscore=0 priorityscore=1501 spamscore=0 malwarescore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112290058
Content-Type: text/plain; charset="iso-8859-2"
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sorry, I misunderstood the two functions. pci_endpoint_test_write has fulfi=
lled orig_addr, which is used to dma_map_single. So it ask the device to re=
ad from the dma address, and **writes** to its own dma address/buf.=20

Pls ignore this patch, thanks.

> -----Original Message-----
> From: Li Chen
> Sent: Wednesday, December 29, 2021 2:07 PM
> To: Kishon Vijay Abraham I; Lorenzo Pieralisi; Krzysztof Wilczy=F1ski; Ar=
nd
> Bergmann; Greg Kroah-Hartman; linux-pci@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] misc: pci_endpoint_test: fix misuse of
> COMMAND_READ/WRITE
>=20
> IIUC, COMMAND_WRITE should be set for pci_endpoint_test_write,
> and COMMAND_READ should be set for pci_endpoint_test_read.
>=20
> Signed-off-by: Li Chen <lchen@ambarella.com>
> ---
>  drivers/misc/pci_endpoint_test.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint=
_test.c
> index 2ed7e3aaff3a8..ea7a90830932d 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -551,12 +551,12 @@ static bool pci_endpoint_test_write(struct
> pci_endpoint_test *test,
>  	pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_IRQ_TYPE,
> irq_type);
>  	pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_IRQ_NUMBER, 1);
>  	pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_COMMAND,
> -				 COMMAND_READ);
> +				 COMMAND_WRITE);
>=20
>  	wait_for_completion(&test->irq_raised);
>=20
>  	reg =3D pci_endpoint_test_readl(test, PCI_ENDPOINT_TEST_STATUS);
> -	if (reg & STATUS_READ_SUCCESS)
> +	if (reg & STATUS_WRITE_SUCCESS)
>  		ret =3D true;
>=20
>  	dma_unmap_single(dev, orig_phys_addr, size + alignment,
> @@ -643,7 +643,7 @@ static bool pci_endpoint_test_read(struct
> pci_endpoint_test *test,
>  	pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_IRQ_TYPE,
> irq_type);
>  	pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_IRQ_NUMBER, 1);
>  	pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_COMMAND,
> -				 COMMAND_WRITE);
> +				 COMMAND_READ);
>=20
>  	wait_for_completion(&test->irq_raised);
>=20
> --
> 2.34.1

Regards,
Li

**********************************************************************
This email and attachments contain Ambarella Proprietary and/or Confidentia=
l Information and is intended solely for the use of the individual(s) to wh=
om it is addressed. Any unauthorized review, use, disclosure, distribute, c=
opy, or print is prohibited. If you are not an intended recipient, please c=
ontact the sender by reply email and destroy all copies of the original mes=
sage. Thank you.