Date:   Wed, 29 Dec 2021 13:07:23 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Lars-Peter Clausen <lars@metafoo.de>, linux-iio@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        William Breathitt Gray <vilhelm.gray@gmail.com>,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v2 13/23] counter: Provide alternative counter
 registration functions
Message-ID: <20211229120723.y5dlbmbvmg4ogq26@pengutronix.de>
References: <20211227094526.698714-1-u.kleine-koenig@pengutronix.de>
 <20211227094526.698714-14-u.kleine-koenig@pengutronix.de>
 <20211228180017.37c2703d@jic23-huawei>
 <20211229112732.23aefj6hcv7ymija@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="5w552i7ktf2x4f4g"
Content-Disposition: inline
In-Reply-To: <20211229112732.23aefj6hcv7ymija@pengutronix.de>
Precedence: bulk


--5w552i7ktf2x4f4g
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Wed, Dec 29, 2021 at 12:27:32PM +0100, Uwe Kleine-K=F6nig wrote:
> > Personal inclination here would be to keep the elements in here
> > in the same order as in counter_register() where it doesn't matter
> > in the interests of slightly easier comparison of the code.
>=20
> I reordered a bit because counter_register fails to undo ida_alloc() in
> the error path. However I might have missed that some initialisation has
> to be done before calling counter_chrdev_add().

Another issue in counter_register() is: If counter_sysfs_add() fails,
put_device() is called which eventually calls counter_device_release()
-> counter_chrdev_remove() -> kfifo_free(). I think it's not a real
problem, but it's ugly because because counter_chrdev_add()
-> kfifo_alloc() wasn't called yet.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--5w552i7ktf2x4f4g
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmHMT3gACgkQwfwUeK3K
7AkvxQf+NQEyz2nLrMETgnBViWuwOhqLb643u36Y1JbzUczPWJkBeiy7k2wKXfjL
cIdvNq7zcSEvqWtjI+U2xaf5LDBWF5S9fFu1XyanTISj1wNao1MVSciQ0FCafSsq
/BtyYrasVbAfJdkqgoOMR071yfzkuck7bgl13m7ZaixOtagWjGn086bVIfTwKuSo
eMZJ7ORej4gDX2DjvIHp2Xqw/YSL0B3kFhpwrT2P/HMMJPNDEMCB9gmKRptD0Vtr
Vf1Mjt1p8Z8xkHNxAowwT44TCC8kJ0TDwRhQSrAqcud7TlBRvJe0x0K0CViB3+YB
HJDT21XMEf8a+OzyxbzZaA4gNVJpMQ==
=Vedz
-----END PGP SIGNATURE-----

--5w552i7ktf2x4f4g--