Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933256AbXA2HWs (ORCPT ); Mon, 29 Jan 2007 02:22:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933247AbXA2HWs (ORCPT ); Mon, 29 Jan 2007 02:22:48 -0500 Received: from rhun.apana.org.au ([64.62.148.172]:3956 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933181AbXA2HWr (ORCPT ); Mon, 29 Jan 2007 02:22:47 -0500 Date: Mon, 29 Jan 2007 18:21:46 +1100 From: Herbert Xu To: Andrew Morton , Ingo Molnar , "David S. Miller" Cc: Michal Piotrowski , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Dipankar Sarma , "Paul E. McKenney" Subject: Re: 2.6.20-rc6-mm1 Message-ID: <20070129072146.GA30334@gondor.apana.org.au> References: <45BD2424.7020604@googlemail.com> <20070129052929.GA29456@gondor.apana.org.au> <20070128224312.50f89360.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070128224312.50f89360.akpm@osdl.org> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1244 Lines: 29 On Sun, Jan 28, 2007 at 10:43:12PM -0800, Andrew Morton wrote: > > > IIRC Ingo had made fixes for the networking stack in his rt tree since > > the networking code assumes in lots of places that rcu_read_lock > > disables preemption. > > oh. We'd better find those fixes then. I wonder what other code made that > (rather hacky) assumption? I guess we have enough debug stuff in there to > find out.. Actually, maybe I was confusing this with the fixes Ingo had for local_bh_disable vs. preemption in the -rt tree. Ingo, do you have preemptible RCU support in your -rt tree and if so did you have to fix the networking stack to behave correctly with it? It could also be that the fixes for local_bh_disable also masked any problems that would trigger under preemptible RCU. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/