Message-ID: <872b08a5-169e-45da-9e7e-4ece481514c7@gmail.com>
Date:   Wed, 29 Dec 2021 16:22:04 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Content-Language: en-US
To:     Felix Fietkau <nbd@nbd.name>, linux-arm-kernel@lists.infradead.org,
        Russell King <linux@armlinux.org.uk>
Cc:     john@phrozen.org, linux-kernel@vger.kernel.org
References: <20211220211854.89452-1-nbd@nbd.name>
 <20211220211854.89452-5-nbd@nbd.name>
From:   Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH v8 04/14] ARM: Add basic support for Airoha EN7523 SoC
In-Reply-To: <20211220211854.89452-5-nbd@nbd.name>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 20/12/2021 22:18, Felix Fietkau wrote:
> From: John Crispin <john@phrozen.org>
> 
> EN7523 is an armv8 based silicon used inside broadband access type devices
> such as xPON and xDSL. It shares various silicon blocks with MediaTek
> silicon such as the MT7622.
> 
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Bert Vermeulen <bert@biot.com>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> ---
>   arch/arm/Kconfig | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index f0f9e8bec83a..8dcd05ef31cc 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -573,6 +573,18 @@ config ARCH_VIRT
>   	select HAVE_ARM_ARCH_TIMER
>   	select ARCH_SUPPORTS_BIG_ENDIAN
>   
> +config ARCH_AIROHA
> +	bool "Airoha SoC Support"
> +	depends on ARCH_MULTI_V7
> +	select ARM_AMBA
> +	select ARM_GIC
> +	select ARM_GIC_V3
> +	select ARM_PSCI
> +	select HAVE_ARM_ARCH_TIMER
> +	select COMMON_CLK
> +	help
> +	  Support for Airoha EN7523 SoCs
> +

We should add a new subfolder
arm/mach-airoha or add the config in arm/mach-mediatek, as it re-uses part of 
the MediaTek IP.

Please merge this with 3/14

I also wonder if this actually boots. I suspect we need DT_MACHINE_START() macro 
and the compatibles defined. It's many years ago I did this for MediaTek but I 
remember that the system won't boot without that. Maybe things have changed over 
time though.

Regards,
Matthias

>   #
>   # This is sorted alphabetically by mach-* pathname.  However, plat-*
>   # Kconfigs may be included either alphabetically (according to the
>