Date:   Wed, 29 Dec 2021 16:47:07 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        linux-iio@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        William Breathitt Gray <vilhelm.gray@gmail.com>,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v2 13/23] counter: Provide alternative counter
 registration functions
Message-ID: <20211229154707.hlmf5azc63hzdfd5@pengutronix.de>
References: <20211227094526.698714-1-u.kleine-koenig@pengutronix.de>
 <20211227094526.698714-14-u.kleine-koenig@pengutronix.de>
 <20211228180017.37c2703d@jic23-huawei>
 <1d3c1df9-42b8-e451-f622-32d8c1e6d1b5@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="dw7yj4rm5wxybk7e"
Content-Disposition: inline
In-Reply-To: <1d3c1df9-42b8-e451-f622-32d8c1e6d1b5@linux.intel.com>
Precedence: bulk


--dw7yj4rm5wxybk7e
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 29, 2021 at 03:49:29PM +0200, Jarkko Nikula wrote:
> On 12/28/21 20:00, Jonathan Cameron wrote:
> > On Mon, 27 Dec 2021 10:45:16 +0100
> > Uwe Kleine-K=F6nig         <u.kleine-koenig@pengutronix.de> wrote:
> > > +	if (err < 0)
> > > +		goto err_chrdev_add;
> > > +
> > > +	device_initialize(dev);
> > > +	/* Configure device structure for Counter */
> > > +	dev->type =3D &counter_device_type;
> > > +	dev->bus =3D &counter_bus_type;
> > > +	dev->devt =3D MKDEV(MAJOR(counter_devt), id);
> >=20
> > As 0-day pointed out id not initialized.
> >=20
> This was the reason why second counter instance initialization failed for=
 me
> when testing the patch 17. I fixed it locally by changing the line a few
> rows above the MKDEV():
>=20
> -	dev->id =3D err;
> +	dev->id =3D id =3D err;

Instead I dropped id for v3. I failed to check this mailthread again
before sending it out. So I missed your feedback. I will go through it
again and comment later.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--dw7yj4rm5wxybk7e
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmHMgvgACgkQwfwUeK3K
7AmXCAf+KnF1zl1IJybEDHcaQ1jKTFYZELGukiDDi+3mWsaTLzTa4AMXocctcg1b
SgvDXuniLp/ZBqutfZbYvceNVxJs+fg+qjcf2ZkM/3EceCkl7IZA+5SC6FZHeN48
ODUHyJMVfv+hByDhYwIYlYbBnroZNCCsS7lNicWn48VNcj2asUgbxO9c8Sfl2MmO
71dotVhYwc2KYyz+gMAbuLA8hLgBIcW6QXXw5PpCjJx0cP1VjotgGyEamp01IMDu
FFOhDKFG31oI3dSoXBNsH+OtBo0OxyYJLgVLqt9JLcoT7dZguDzpAwYqoq1U8YQB
BJ9Z8b1bwGGrJQV2SJwkbBFfZvK9Qg==
=koAV
-----END PGP SIGNATURE-----

--dw7yj4rm5wxybk7e--