From:   "Khandelwal, Rajat" <rajat.khandelwal@intel.com>
To:     "mika.westerberg@linux.intel.com" <mika.westerberg@linux.intel.com>,
        "Westerberg, Mika" <mika.westerberg@intel.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>
Subject: RE: [PATCH] Keep polling IPC status if it reads IPC_STATUS_BUSY or
 IPC_STATUS_ERR until timeout expires
Thread-Topic: [PATCH] Keep polling IPC status if it reads IPC_STATUS_BUSY or
 IPC_STATUS_ERR until timeout expires
Thread-Index: AQHX/LjrrHoyodxf402g1xww8njLyqxJpH9g
Date:   Wed, 29 Dec 2021 16:13:56 +0000
Message-ID: <CO1PR11MB4835D217B78F17BA6AD79F0096449@CO1PR11MB4835.namprd11.prod.outlook.com>
References: <20211229132948.4738-1-rajat.khandelwal@intel.com>
In-Reply-To: <20211229132948.4738-1-rajat.khandelwal@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SnBtdBmfINNY7pnCP+Sq51avA0ZyNYDeN3MFXHRjOfn/OUi1Y0FA52eRpEtl?=
 =?us-ascii?Q?+j1xBia68HNcWdXQJjWdf0zUaaG951e88UgOnYx6WKTEGdtQvCfhZKCwueOQ?=
 =?us-ascii?Q?0R0T3qyqvSVxafGte7sicFUgfW0zq35TOFGKTmeuzVvoRIb9RMu1ahby5AdS?=
 =?us-ascii?Q?YDpZabj99XYj+G4PtfL73w7jEDh5nPXMBWQJ6i8UtATzQ6Uc51gy3H+fBCf4?=
 =?us-ascii?Q?sUU/v52+UN/6RDNWf3lG6HbWxYzxnZOovm15qwSTzt+0/jaM4Cv+FXrQDz4+?=
 =?us-ascii?Q?L0Nt0olIQbKHsgTir5mLcODj2elWfxVf8snEpcZrfUKCRSZA3ujZoiUF2NkX?=
 =?us-ascii?Q?TzxN+MjughnK3D7uwyqJ4ZemN8M8XlreWU+DRmifzUJliqOq6EEb+oPxNewO?=
 =?us-ascii?Q?7g7aTXuBlG3K6yu63jXVIC73nExo+enQtR8qjVB2qVXG97tzqpvWMz2bR2L8?=
 =?us-ascii?Q?0K3fT0OMdujRFkLBkgYO18elUrzKnRuG8JbusX74/8JA2G0MCltSyCZbClMm?=
 =?us-ascii?Q?2ZqY2niC7JlpfyFlXh7TxaRaD0Zcv1Xe1cMchu/D3DwpdDCNAk7im7YU4jMT?=
 =?us-ascii?Q?RNVEOznpCx14wmBRv8hfapcddpFK0qzCdAWjBDYQSTmlevr44hAdRvXn48Ep?=
 =?us-ascii?Q?l8Q1rdO5nmW+82VxxTpuhOP0W1jhymmItVHob71oKZqFr+p2uTOXi0cyWtQG?=
 =?us-ascii?Q?9WwdKGBmolmrXEJoe+fO7LrnB0avqZOrcy4iqaKR3eoA8L1dil1SHrhI+J51?=
 =?us-ascii?Q?CiLfIUkdml49sVjepIEDQEVwrZ/9Wvpq/tJkVpQUQtQ8SjJ4UDZml5OQY6uh?=
 =?us-ascii?Q?0hh4C8zPHhVXU2ZtRvspNxfpHghCfhtlbV3JMQ1M9UpDxMMPT77YtynI/tIN?=
 =?us-ascii?Q?zA3FphCLe+gWpAhZKkmXR+Yyqdm5510i6/8uT1Hz29tiQl620bflPeeVOQUZ?=
 =?us-ascii?Q?vj5xBVHGs5/N4DnD0kRroz8L2bUjqrWHitdj80qL/BDFc5dALQ80mro4fQDS?=
 =?us-ascii?Q?at6hD/bbAWj26QU6OZDeLb4+6Qm0EkyWSvEJjzQNfoU2cdl/+4nQV9QNPaxb?=
 =?us-ascii?Q?zn+GThI/MoMDP9p/JuaizsvcqtVwgjXVyrHDm6lnBV82rdyWO3ZpRrebO5SY?=
 =?us-ascii?Q?Hws1yBriZRDzdybvx1/+jGqAeGysa+/eQ4g165ldTA2VNsVhx0nTPkMO3o5c?=
 =?us-ascii?Q?Jkyf5PQXMUUniroHOhwJhsZdmoJIMW40ygb9ltcPmNMKdQTCoa9tNg+AJupI?=
 =?us-ascii?Q?6p6i0iSK0bXYI31akuhRupB8AY47spaZP/ZcdM9vf/CAGL1zubHfVpBdpnmj?=
 =?us-ascii?Q?0RuqKMn2KWiJvmM2BRR3NcpWci7A+8pf5cvfX4swXUHI7kRnhO1yaK3WN/mQ?=
 =?us-ascii?Q?OXkQ+YHkULJpYcZTv5PdKaURt6Fk4m7HoX3s2n6rRjhE3zFdF26cPAuXEzvH?=
 =?us-ascii?Q?Zfb8WRfDg/cBGrLVtC9rqg5ZAGziX8Y9ECERpGETZIkxBwbUVXakiNOVarsj?=
 =?us-ascii?Q?ateWeK+5iGXVZX4svSkXWQyremI+EtZUH3bGXiM2llexnfgmp+CPLx2nXUee?=
 =?us-ascii?Q?3WKFKDk4FkATGoVDGxP1Pldrv0ix2B8G6DTaCqTzP5FRWhjdp2Krz5lw+BY8?=
 =?us-ascii?Q?zlkk+v5PZmxrmC3ZjO1QIurM9gsU5K6eS8zorEsE+kBk+2fPwb4RyvmGPJur?=
 =?us-ascii?Q?fuZRiA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4835.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 754d96de-116a-4b8a-c2c5-08d9cae6374c
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2021 16:13:56.7608
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: a6dWsnTCUYr4ro3LfVpjy9XYmQ9iA31V8uTfWEXzVjBu84IelSwpe8d4c45H2OoQQo5zH0onVT+xg7SoS6vM64+bmomPv6TOdUUR4McAoLU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0064
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi @Westerberg, Mika
This was the original message!

-----Original Message-----
From: Khandelwal, Rajat <rajat.khandelwal@intel.com>=20
Sent: Wednesday, December 29, 2021 7:00 PM
To: mika.westerberg@linux.intel.com
Cc: Khandelwal, Rajat <rajat.khandelwal@intel.com>; linux-kernel@vger.kerne=
l.org; platform-driver-x86@vger.kernel.org
Subject: [PATCH] Keep polling IPC status if it reads IPC_STATUS_BUSY or IPC=
_STATUS_ERR until timeout expires

The current implementation returns -EIO if and when IPC_STATUS_ERR is retur=
ned and returns -ETIMEDOUT even if the status is busy.
This patch polls the IPC status even if IPC_STATUS_ERR is returned until ti=
meout expires and returns -EBUSY if the status shows busy.
Observed in multiple scenarios, trying to fetch the status of IPC after it =
shows ERR sometimes eradicates the ERR status.

Signed-off-by: Rajat-Khandelwal <rajat.khandelwal@intel.com>
---
 drivers/platform/x86/intel_scu_ipc.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/intel_scu_ipc.c b/drivers/platform/x86/in=
tel_scu_ipc.c
index 7cc9089d1e14..91f716e84474 100644
--- a/drivers/platform/x86/intel_scu_ipc.c
+++ b/drivers/platform/x86/intel_scu_ipc.c
@@ -233,17 +233,19 @@ static inline u32 ipc_data_readl(struct intel_scu_ipc=
_dev *scu, u32 offset)  static inline int busy_loop(struct intel_scu_ipc_de=
v *scu)  {
 	unsigned long end =3D jiffies + IPC_TIMEOUT;
+	u32 status;
=20
 	do {
-		u32 status;
-
 		status =3D ipc_read_status(scu);
 		if (!(status & IPC_STATUS_BUSY)) {
-			return (status & IPC_STATUS_ERR) ? -EIO : 0;
+			if (!(status & IPC_STATUS_ERR))
+				return 0;
+		}
=20
 		usleep_range(50, 100);
 	} while (time_before(jiffies, end));
=20
+	if (status & IPC_STATUS_BUSY)
+		return -EBUSY;
+	if (status & IPC_STATUS_ERR)
+		return -EIO;
+
 	return -ETIMEDOUT;
 }
=20
--
2.17.1