Date: Mon, 29 Jan 2007 00:59:40 -0800
From: Andrew Morton <akpm@osdl.org>
To: Andi Kleen <ak@suse.de>
Cc: "Parag Warudkar" <parag.warudkar@gmail.com>, thunder7@xs4all.nl,
       linux-kernel@vger.kernel.org
Subject: Re: 2.6.20-rc6-mm1: linker error with arch_setup_additional_pages
Message-Id: <20070129005940.04c3d6d1.akpm@osdl.org>
In-Reply-To: <200701290351.54270.ak@suse.de>
References: <82e4877d0701280834n75d3d0d3ja7a35d5ea0e7fa4f@mail.gmail.com>
	<82e4877d0701281444h333c581fr66d60cca9d03749d@mail.gmail.com>
	<200701290351.54270.ak@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 882
Lines: 23

On Mon, 29 Jan 2007 03:51:54 +0100
Andi Kleen <ak@suse.de> wrote:

> 
> > I think the easy and correct fix for this situation is defining
> > CONFIG_ARCH_HAS_SETUP_ADDITIONAL_PAGES on x86_64 only if
> > IA32_EMULATION is defined. (Because x86_64 proper doesn't seem to
> > require arch_setup_additional_pages() only IA32 emulation requires
> > it.)
> >
> > The patch below should fix it. (Please use attachment - less chance of
> > whitespace issues. Sorry no control over mail client atm)
> 
> A more elegant solution would be to do away with the CONFIG
> and switch to a weak function in the caller.
> 

Now why didn't I think of that?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/