MIME-Version: 1.0
References: <4C0186FE-729D-4F77-947D-11933BA38818@gmail.com>
In-Reply-To: <4C0186FE-729D-4F77-947D-11933BA38818@gmail.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Wed, 29 Dec 2021 11:08:14 -0800
Message-ID: <CAM9d7ciroZswudPXAAs9Zo3_veFMugJJZ4XZWhGSKHdFPcDOjQ@mail.gmail.com>
Subject: Re: Lock problems in linux/tools/perf/util/dso.c
To:     Ryan Cai <ycaibb@gmail.com>
Cc:     Adrian Hunter <adrian.hunter@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hello,

On Wed, Dec 22, 2021 at 3:33 AM Ryan Cai <ycaibb@gmail.com> wrote:
>
> Hi, I found a potential lock problem in dso_data_get_fd. Because the inconsistent branch conditions of pthread_mutex_lock(&dso__data_open_lock) and pthread_mutex_unlock(&dso__data_open_lock), it is possible that the lock dso__data_open_lock is not released in the dso_data_get_fd. Also, I have a question on why the branch condition of pthread_mutex_lock(&dso__data_open_lock) is <0. I think that the branch condition should be !=0, because pthread_mutex_lock would return 0 when succeeding. Looking forward to further discussion. One this bug is confirmed, I can send a patch.

Please fix your mail client to wrap around 80 characters.

1. dso__data_get_fd() should be paired with dso__data_put_fd()
   when it returns non-negative.  It'd unlock the mutex.

2. I've checked the man page and it seems you're right.
   It just says that it'd return an error number or zero.

   https://linux.die.net/man/3/pthread_mutex_lock

Thanks,
Namhyung


>
>
>
> https://github.com/torvalds/linux/blob/e851dfae4371d3c751f1e18e8eb5eba993de1467/tools/perf/util/dso.c#L708-L722
>
>
>
> Best,
>
> Ryan
>
>
>
>