MIME-Version: 1.0
References: <CAJ-ks9kd6wWi1S8GSCf1f=vJER=_35BGZzLnXwz36xDQPacyRw@mail.gmail.com>
 <CAJ-ks9=41PuzGkXmi0-aZPEWicWJ5s2gW2zL+jSHuDjaJ5Lhsg@mail.gmail.com>
 <20211228155433.3b1c71e5@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <CA+FuTSeDTJxbPvN6hkXFMaBspVHwL+crOxzC2ukWRzxvKma9bA@mail.gmail.com>
In-Reply-To: <CA+FuTSeDTJxbPvN6hkXFMaBspVHwL+crOxzC2ukWRzxvKma9bA@mail.gmail.com>
From:   Tamir Duberstein <tamird@gmail.com>
Date:   Wed, 29 Dec 2021 14:46:41 -0500
Message-ID: <CAJ-ks9=3o+rVJd5ztYbkgpcYiWjV+3qajCgOmM7AfjhoZvuOHw@mail.gmail.com>
Subject: Re: [PATCH] net: check passed optlen before reading
To:     Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc:     Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        David Ahern <dsahern@kernel.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

I'm having some trouble sending this using git send-email because of
the firewall I'm behind.

Please pull from
  git://github.com/tamird/linux raw-check-optlen
to get these changes:
  280c5742aab2 ipv6: raw: check passed optlen before reading

If this is not acceptable, I'll send the patch again when I'm outside
the firewall. Apologies.

On Wed, Dec 29, 2021 at 10:09 AM Willem de Bruijn
<willemdebruijn.kernel@gmail.com> wrote:
>
> On Tue, Dec 28, 2021 at 6:54 PM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Tue, 28 Dec 2021 16:02:29 -0500 Tamir Duberstein wrote:
> > > Errant brace in the earlier version.
> > >
> > > From 8586be4d72c6c583b1085d2239076987e1b7c43a Mon Sep 17 00:00:00 2001
> > > From: Tamir Duberstein <tamird@gmail.com>
> > > Date: Tue, 28 Dec 2021 15:09:11 -0500
> > > Subject: [PATCH v2] net: check passed optlen before reading
> > >
> > > Add a check that the user-provided option is at least as long as the
> > > number of bytes we intend to read. Before this patch we would blindly
> > > read sizeof(int) bytes even in cases where the user passed
> > > optlen<sizeof(int), which would potentially read garbage or fault.
> > >
> > > Discovered by new tests in https://github.com/google/gvisor/pull/6957 .
> > >
> > > Signed-off-by: Tamir Duberstein <tamird@gmail.com>
> >
> > Your patches are corrupted by your email client.
> >
> > Can you try sending the latest version with git send-email?
>
> Then perhaps also update the subject line to make it more clear where
> this applies: "ipv6: raw: check passed optlen before reading".